From: Robert Richter <rrichter@marvell.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: "bp@alien8.de" <bp@alien8.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"benh@amazon.com" <benh@amazon.com>,
"ronenk@amazon.com" <ronenk@amazon.com>,
"talel@amazon.com" <talel@amazon.com>,
"jonnyc@amazon.com" <jonnyc@amazon.com>,
"hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors
Date: Thu, 19 Sep 2019 06:33:42 +0000 [thread overview]
Message-ID: <20190919063334.x2rfk33swyjqur3q@rric.localdomain> (raw)
In-Reply-To: <20190912145305.21008-2-hhhawa@amazon.com>
On 12.09.19 15:53:04, Hanna Hawa wrote:
> Add an API for EDAC device to report multiple errors with same type.
>
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
> drivers/edac/edac_device.c | 91 ++++++++++++++++++++++++++++++++++++++
> drivers/edac/edac_device.h | 40 +++++++++++++++++
> 2 files changed, 131 insertions(+)
>
> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
> index 65cf2b9355c4..78ac44103acc 100644
> --- a/drivers/edac/edac_device.c
> +++ b/drivers/edac/edac_device.c
> @@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
> block ? block->name : "N/A", msg);
> }
> EXPORT_SYMBOL_GPL(edac_device_handle_ue);
> +
> +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> + unsigned int count, int inst_nr, int block_nr,
> + const char *msg)
> +{
Please do not add a copy here, instead modify the existing function
and share the code with both, old and new functions.
Thanks,
-Robert
next prev parent reply other threads:[~2019-09-19 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 14:53 [PATCH v2 0/2] Add an API for edac device, for mulriple errors Hanna Hawa
2019-09-12 14:53 ` [PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors Hanna Hawa
2019-09-19 6:33 ` Robert Richter [this message]
2019-09-19 7:24 ` Hawa, Hanna
2019-09-12 14:53 ` [PATCH v2 2/2] edac: move edac_device_handle_*() API functions to header Hanna Hawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919063334.x2rfk33swyjqur3q@rric.localdomain \
--to=rrichter@marvell.com \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).