From: Borislav Petkov <bp@alien8.de>
To: Robert Richter <rrichter@marvell.com>
Cc: Hanna Hawa <hhhawa@amazon.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"benh@amazon.com" <benh@amazon.com>,
"ronenk@amazon.com" <ronenk@amazon.com>,
"talel@amazon.com" <talel@amazon.com>,
"jonnyc@amazon.com" <jonnyc@amazon.com>,
"hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors
Date: Tue, 1 Oct 2019 12:25:39 +0200 [thread overview]
Message-ID: <20191001102539.GB5390@zn.tnic> (raw)
In-Reply-To: <20191001094659.5of5ul2tof6s75px@rric.localdomain>
On Tue, Oct 01, 2019 at 09:47:07AM +0000, Robert Richter wrote:
> If you move to static inline for edac_device_handle_{ce,ue} the
> symbols vanish and this breaks the abi. That's why the split in two
> patches.
ABI issues do not concern upstream. And that coming from me working at a
company who dance a lot to make ABI happy.
Also, I'm missing the reasoning why you use the ABI as an argument at
all: do you know of a particular case where people are thinking of
backporting this or this is all hypothetical.
> Your comment to not have a __ version as a third variant of the
> interface makes sense to me. But to keep ABI your patch still needs to
> be split.
Not really - normally, when you fix ABI issues with symbols
disappearing, all of a sudden, you add dummy ones so that the ABI
checker is happy.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-10-01 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 19:17 [PATCH v4 0/2] Add an API for edac device, for mulriple errors Hanna Hawa
2019-09-23 19:17 ` [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors Hanna Hawa
2019-09-30 14:50 ` Borislav Petkov
2019-10-01 6:56 ` Robert Richter
2019-10-01 8:32 ` Borislav Petkov
2019-10-01 9:47 ` Robert Richter
2019-10-01 10:25 ` Borislav Petkov [this message]
2019-10-01 10:53 ` Robert Richter
2019-10-02 9:25 ` Hawa, Hanna
2019-10-04 16:57 ` [PATCH -v2] EDAC/device: Rework error logging API Borislav Petkov
2019-09-23 19:17 ` [PATCH v4 2/2] edac: move edac_device_handle_*() API functions to header Hanna Hawa
2019-09-24 6:33 ` [PATCH v4 0/2] Add an API for edac device, for mulriple errors Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001102539.GB5390@zn.tnic \
--to=bp@alien8.de \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ronenk@amazon.com \
--cc=rrichter@marvell.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).