From: Robert Richter <rrichter@marvell.com>
To: Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>
Cc: James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 00/19] EDAC: Rework edac_mc and ghes drivers
Date: Thu, 10 Oct 2019 20:25:01 +0000 [thread overview]
Message-ID: <20191010202418.25098-1-rrichter@marvell.com> (raw)
This patch set is a rework of the ghes_edac and edac_mc driver. It
addresses issues found during code review and while working with the
code. The changes include:
* improve function interfaces and data structures to decrease
complexity such as number of function arguments, unused data, etc.
(#1, #2, #6, #10, #12, #13),
* add helper functions and factor out code (#3, #8, #9, #14)
* fix style issues found by checkpatch (#4)
* improve code readability (#5, #7, #11)
* use of standard kernel macros (#15)
* code unification (#16, #17, #18)
* documentation updates (#19)
This series contains some patches that have been posted and reviewed
earlier here:
https://lore.kernel.org/patchwork/cover/1093488/
Review comments have been addressed and the following changes have
been made to those patches:
* rebased onto ras:edac-for-next (v5.4-rc1 based)
* reworded patch descriptions
* dropped hunk that only reorders code in "EDAC, ghes: Remove
pvt->detail_location string"
* updated description for edac_get_dimm_by_index()
* updated description for edac_get_dimm()
* small style changes in "EDAC: Replace EDAC_DIMM_PTR() macro with
edac_get_dimm() function"
* use unsigned type for dimm->idx to avoid need for negative range
check
* fixed mci_for_each_dimm() loop in i5100_init_csrows()
* fixed off-by-one in mci_for_each_dimm()
Robert Richter (19):
EDAC: Replace EDAC_DIMM_PTR() macro with edac_get_dimm() function
EDAC: Remove EDAC_DIMM_OFF() macro
EDAC: Introduce mci_for_each_dimm() iterator
EDAC, mc: Do not BUG_ON() in edac_mc_alloc()
EDAC, mc: Reduce indentation level in edac_mc_handle_error()
EDAC, mc: Remove per layer counters
EDAC, mc: Rename iterator variable to idx
EDAC, mc: Split edac_mc_alloc() into smaller functions
EDAC, mc: Reorder functions edac_mc_alloc*()
EDAC, mc: Rework edac_raw_mc_handle_error() to use struct dimm_info
EDAC: Remove misleading comment in struct edac_raw_error_desc
EDAC: Store error type in struct edac_raw_error_desc
EDAC, mc: Determine mci pointer from the error descriptor
EDAC, mc: Create new function edac_inc_csrow()
EDAC, ghes: Use standard kernel macros for page calculations
EDAC, ghes: Fix grain calculation
EDAC, ghes: Remove intermediate buffer pvt->detail_location
EDAC, ghes: Unify trace_mc_event() code with edac_mc driver
EDAC, Documentation: Describe CPER module definition and DIMM ranks
Documentation/admin-guide/ras.rst | 31 +-
drivers/edac/edac_mc.c | 478 +++++++++++++++---------------
drivers/edac/edac_mc.h | 8 +-
drivers/edac/edac_mc_sysfs.c | 65 ++--
drivers/edac/ghes_edac.c | 55 ++--
drivers/edac/i10nm_base.c | 3 +-
drivers/edac/i3200_edac.c | 3 +-
drivers/edac/i5000_edac.c | 5 +-
drivers/edac/i5100_edac.c | 14 +-
drivers/edac/i5400_edac.c | 3 +-
drivers/edac/i7300_edac.c | 3 +-
drivers/edac/i7core_edac.c | 3 +-
drivers/edac/ie31200_edac.c | 7 +-
drivers/edac/pnd2_edac.c | 4 +-
drivers/edac/sb_edac.c | 2 +-
drivers/edac/skx_base.c | 3 +-
drivers/edac/ti_edac.c | 2 +-
include/linux/edac.h | 153 +++++-----
18 files changed, 401 insertions(+), 441 deletions(-)
--
2.20.1
next reply other threads:[~2019-10-10 20:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 20:25 Robert Richter [this message]
2019-10-10 20:25 ` [PATCH 01/19] EDAC: Replace EDAC_DIMM_PTR() macro with edac_get_dimm() function Robert Richter
2019-10-11 9:58 ` Mauro Carvalho Chehab
2019-10-11 11:38 ` Robert Richter
2019-10-10 20:25 ` [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro Robert Richter
2019-10-11 10:09 ` Mauro Carvalho Chehab
2019-10-11 11:36 ` Robert Richter
2019-10-10 20:25 ` [PATCH 03/19] EDAC: Introduce mci_for_each_dimm() iterator Robert Richter
2019-10-11 10:14 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 04/19] EDAC, mc: Do not BUG_ON() in edac_mc_alloc() Robert Richter
2019-10-11 10:15 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 05/19] EDAC, mc: Reduce indentation level in edac_mc_handle_error() Robert Richter
2019-10-10 22:10 ` Joe Perches
2019-10-11 6:50 ` Robert Richter
2019-10-11 10:20 ` Mauro Carvalho Chehab
2019-10-11 10:50 ` Joe Perches
2019-10-11 12:08 ` Robert Richter
2019-10-11 14:49 ` Joe Perches
2019-10-11 10:17 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 06/19] EDAC, mc: Remove per layer counters Robert Richter
2019-10-11 10:40 ` Mauro Carvalho Chehab
2019-10-14 11:12 ` Robert Richter
2019-10-10 20:25 ` [PATCH 07/19] EDAC, mc: Rename iterator variable to idx Robert Richter
2019-10-11 10:41 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 08/19] EDAC, mc: Split edac_mc_alloc() into smaller functions Robert Richter
2019-10-11 10:43 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 09/19] EDAC, mc: Reorder functions edac_mc_alloc*() Robert Richter
2019-10-11 10:45 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 10/19] EDAC, mc: Rework edac_raw_mc_handle_error() to use struct dimm_info Robert Richter
2019-10-11 10:48 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 11/19] EDAC: Remove misleading comment in struct edac_raw_error_desc Robert Richter
2019-10-11 10:49 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 12/19] EDAC: Store error type " Robert Richter
2019-10-11 10:54 ` Mauro Carvalho Chehab
2019-10-14 11:47 ` Robert Richter
2019-10-10 20:25 ` [PATCH 13/19] EDAC, mc: Determine mci pointer from the error descriptor Robert Richter
2019-10-11 10:56 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 14/19] EDAC, mc: Create new function edac_inc_csrow() Robert Richter
2019-10-11 11:08 ` Mauro Carvalho Chehab
2019-10-14 11:58 ` Robert Richter
2019-10-10 20:25 ` [PATCH 15/19] EDAC, ghes: Use standard kernel macros for page calculations Robert Richter
2019-10-11 11:10 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 16/19] EDAC, ghes: Fix grain calculation Robert Richter
2019-10-11 11:22 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 17/19] EDAC, ghes: Remove intermediate buffer pvt->detail_location Robert Richter
2019-10-11 11:20 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 18/19] EDAC, ghes: Unify trace_mc_event() code with edac_mc driver Robert Richter
2019-10-11 11:23 ` Mauro Carvalho Chehab
2019-10-10 20:25 ` [PATCH 19/19] EDAC, Documentation: Describe CPER module definition and DIMM ranks Robert Richter
2019-10-11 11:29 ` Mauro Carvalho Chehab
2019-10-10 20:36 ` [PATCH 00/19] EDAC: Rework edac_mc and ghes drivers Robert Richter
2019-10-14 12:00 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010202418.25098-1-rrichter@marvell.com \
--to=rrichter@marvell.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).