From: Borislav Petkov <bp@alien8.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"bberg@redhat.com" <bberg@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"ckellner@redhat.com" <ckellner@redhat.com>
Subject: Re: [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages
Date: Fri, 18 Oct 2019 21:40:17 +0200 [thread overview]
Message-ID: <20191018194017.GE17053@zn.tnic> (raw)
In-Reply-To: <0f78feb77feba6d3add74a46a16b9d0b3b9c3653.camel@linux.intel.com>
On Fri, Oct 18, 2019 at 08:55:17AM -0700, Srinivas Pandruvada wrote:
> I assume that someone is having performance issues or occasion reboots,
> look at the logs. Is it a fair assumption?
Yes, that is a valid use case IMO.
> But if a system is running at up to 87.5% of duty cycle on top of
> lowest possible frequency of around 800MHz, someone will notice.
Yes, but that doesn't justify for those printk statements to be
KERN_CRIT. They're just fine as warnings.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-10-18 19:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2c2b65c23be3064504566c5f621c1f37bf7e7326.camel@redhat.com>
2019-10-14 21:21 ` [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages Srinivas Pandruvada
2019-10-14 21:21 ` [PATCH 2/2] x86, mce: Add additional kernel boot parameter Srinivas Pandruvada
2019-10-14 21:36 ` [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages Borislav Petkov
2019-10-14 22:27 ` Luck, Tony
2019-10-15 8:36 ` Borislav Petkov
2019-10-15 8:52 ` Peter Zijlstra
2019-10-15 13:43 ` Srinivas Pandruvada
2019-10-14 22:41 ` Srinivas Pandruvada
2019-10-15 8:46 ` Borislav Petkov
2019-10-15 14:01 ` Srinivas Pandruvada
2019-10-15 8:48 ` Peter Zijlstra
2019-10-15 13:31 ` Srinivas Pandruvada
2019-10-16 8:14 ` Peter Zijlstra
2019-10-16 14:00 ` Borislav Petkov
2019-10-17 21:31 ` Luck, Tony
2019-10-17 21:44 ` Borislav Petkov
2019-10-17 23:53 ` Luck, Tony
2019-10-18 6:46 ` Borislav Petkov
2019-10-18 7:17 ` Peter Zijlstra
2019-10-18 12:26 ` Srinivas Pandruvada
2019-10-18 13:23 ` Borislav Petkov
2019-10-18 15:55 ` Srinivas Pandruvada
2019-10-18 19:40 ` Borislav Petkov [this message]
2019-10-18 18:02 ` Luck, Tony
2019-10-18 19:45 ` Borislav Petkov
2019-10-18 20:38 ` Luck, Tony
2019-10-19 8:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018194017.GE17053@zn.tnic \
--to=bp@alien8.de \
--cc=bberg@redhat.com \
--cc=ckellner@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).