From: Borislav Petkov <bp@alien8.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, bberg@redhat.com, x86@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, ckellner@redhat.com
Subject: Re: [RFC][PATCH] x86, mce, therm_throt: Optimize notifications of thermal throttle
Date: Tue, 5 Nov 2019 21:56:17 +0100 [thread overview]
Message-ID: <20191105205617.GF28418@zn.tnic> (raw)
In-Reply-To: <810bfb95a42090ff64f86e4154e2bd2cfda29f27.camel@linux.intel.com>
On Tue, Nov 05, 2019 at 12:36:32PM -0800, Srinivas Pandruvada wrote:
> > That wants to be a bool judging by the context it is used in.
> I can change to bool, just didn't use it
> https://yarchive.net/comp/linux/bool.html
And are you using it in a union or where the size of bool - which is
implementation-specific - plays any role, esp. in your particular use
case?
> They are architectural MSRs and the fact that we are getting called
> means that they are enabled by looking at CPUID bits.
If the CPUID bits guarantees their presence, then the error handling is
not absolutely necessary.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-11-05 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 0:19 [RFC][PATCH] x86, mce, therm_throt: Optimize notifications of thermal throttle Srinivas Pandruvada
2019-11-05 14:44 ` Borislav Petkov
2019-11-05 20:36 ` Srinivas Pandruvada
2019-11-05 20:56 ` Borislav Petkov [this message]
2019-11-05 21:21 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105205617.GF28418@zn.tnic \
--to=bp@alien8.de \
--cc=bberg@redhat.com \
--cc=ckellner@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).