From: Borislav Petkov <bp@alien8.de>
To: Christoph Hellwig <hch@lst.de>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, mchehab@kernel.org,
tony.luck@intel.com, james.morse@arm.com, rrichter@marvell.com,
yash.shah@sifive.com, linux-riscv@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v2] riscv: move sifive_l2_cache.c to drivers/soc
Date: Thu, 7 Nov 2019 12:07:08 +0100 [thread overview]
Message-ID: <20191107110707.GE19501@zn.tnic> (raw)
In-Reply-To: <20191107092039.32240-1-hch@lst.de>
On Thu, Nov 07, 2019 at 10:20:39AM +0100, Christoph Hellwig wrote:
> The sifive_l2_cache.c is in no way related to RISC-V architecture
> memory management. It is a little stub driver working around the fact
> that the EDAC maintainers prefer their drivers to be structured in a
> certain way that doesn't fit the SiFive SOCs.
>
> Move the file to drivers/soc and add a Kconfig option for it, as well
> as the whole drivers/soc boilerplate for CONFIG_SOC_SIFIVE.
>
> Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> Changes since v2:
> - don't allow modular builds
> - remove the empty last line in the new Makefile
>
> MAINTAINERS | 1 +
> arch/riscv/mm/Makefile | 1 -
> drivers/edac/Kconfig | 2 +-
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/sifive/Kconfig | 10 ++++++++++
> drivers/soc/sifive/Makefile | 3 +++
> .../riscv/mm => drivers/soc/sifive}/sifive_l2_cache.c | 0
> 8 files changed, 17 insertions(+), 2 deletions(-)
> create mode 100644 drivers/soc/sifive/Kconfig
> create mode 100644 drivers/soc/sifive/Makefile
> rename {arch/riscv/mm => drivers/soc/sifive}/sifive_l2_cache.c (100%)
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2019-11-07 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 9:20 [PATCH v2] riscv: move sifive_l2_cache.c to drivers/soc Christoph Hellwig
2019-11-07 11:07 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107110707.GE19501@zn.tnic \
--to=bp@alien8.de \
--cc=hch@lst.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).