From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34460C43331 for ; Thu, 7 Nov 2019 15:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 070E321882 for ; Thu, 7 Nov 2019 15:40:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="J/uXnq5O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729656AbfKGPkN (ORCPT ); Thu, 7 Nov 2019 10:40:13 -0500 Received: from mail.skyhub.de ([5.9.137.197]:39036 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfKGPkM (ORCPT ); Thu, 7 Nov 2019 10:40:12 -0500 Received: from zn.tnic (p200300EC2F0EAD0005075A6AC44F3288.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:ad00:507:5a6a:c44f:3288]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C44B21EC0CF7; Thu, 7 Nov 2019 16:40:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1573141207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eAnfQdd7N6fknAtquSRK+MKVOqjcPX9i2EkihseahM4=; b=J/uXnq5Opaxro9jWkn9QvvR3qjhsjqEEGuPEbRrhyszkuAqGWUIIrXfa8xW7KHg5a1f9+r EoM1yMK1zzZvt5Ja4YwfvNfdtDsUgMlvKhNms6CsqBVDjy1DxqlxCop/+XmGuD2U1w4eR5 gaQx1BZ6lujT2pAXRmESrOE4ZsDuDhQ= Date: Thu, 7 Nov 2019 16:40:06 +0100 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 0/5] AMD64 EDAC: Check for nodes without memory, etc. Message-ID: <20191107154006.GF19501@zn.tnic> References: <20191106012448.243970-1-Yazen.Ghannam@amd.com> <20191106160607.GC28380@zn.tnic> <20191106195417.GF28380@zn.tnic> <20191107103857.GC19501@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Nov 07, 2019 at 01:47:53PM +0000, Ghannam, Yazen wrote: > BTW, what do you think about loading based on PCI devices? The module > used to do this. I ask because I'm starting to see that future systems may > re-use PCI IDs, and this indicates the same level of hardware support. The reason we switched to family-based autoloading was that almost every new platform would add a new PCI device ID, which would require enablement work... > Just a nit, but this else seems unnecessary right? Maybe it is easier if you look at the function end in the .c file directly as diffs can be confusing: static bool ecc_enabled(struct amd64_pvt *pvt) { ... amd64_info("Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" : "disabled")); if (!ecc_en || !nb_mce_en) return false; else return true; } -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette