From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38287C00454 for ; Thu, 12 Dec 2019 18:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 143F12073D for ; Thu, 12 Dec 2019 18:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="kzsW8/3f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbfLLSco (ORCPT ); Thu, 12 Dec 2019 13:32:44 -0500 Received: from mail.skyhub.de ([5.9.137.197]:47250 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730211AbfLLSco (ORCPT ); Thu, 12 Dec 2019 13:32:44 -0500 Received: from zn.tnic (p200300EC2F0A5A0010289BED6992E3B4.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5a00:1028:9bed:6992:e3b4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 62E201EC01AD; Thu, 12 Dec 2019 19:32:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1576175562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1vhjna/rh+rVgKI+zkzgMfp5mWRrD9pxqEOzOJXpA4Y=; b=kzsW8/3fnaWojTpWx+xOZuFE5jkvWcgtWb0zHWdGQvHha8Z3n16k6oLdIOkrt3LZWH/mbE 40RXHatBBtsZbAG2t/5SMWP8ndSe6ntSi7+6wLxah6GSy4g0pqbbHSZpsh98GMHiVzGYvm Z5LGh7kWizRyKULfw1bLYt/9PqDVdYU= Date: Thu, 12 Dec 2019 19:32:41 +0100 From: Borislav Petkov To: Liran Alon Cc: Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Len Brown , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, Jarkko Sakkinen Subject: Re: [PATCH v4 11/19] x86/cpu: Print VMX flags in /proc/cpuinfo using VMX_FEATURES_* Message-ID: <20191212183241.GI4991@zn.tnic> References: <20191128014016.4389-1-sean.j.christopherson@intel.com> <20191128014016.4389-12-sean.j.christopherson@intel.com> <20191212122646.GE4991@zn.tnic> <4A24DE75-4E68-4EC6-B3F3-4ACB0EE82BF0@oracle.com> <17c6569e-d0af-539c-6d63-f4c07367d8d1@redhat.com> <20191212174357.GE3163@linux.intel.com> <52dd758d-a590-52a6-4248-22d6852b75cd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Dec 12, 2019 at 07:52:55PM +0200, Liran Alon wrote: > Why should CPU VMX features be treated differently than standard CPUID > deduced features? CPU SVM features are also present in /proc/cpuinfo > today (Because they are deduced from CPUID leafs). So it should be > similar. Well, VMX features are not CPUID bits apparently because . And Intel hw folk will give you a bunch, I bet. So Sean needs to do all this dancing to get them to be more usable to other kernel code. SVM feature bits are proper CPUID bits and this is what the cpufeatures glue does - mirro CPUID bits, mainly. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette