From: "Luck, Tony" <tony.luck@intel.com>
To: yu kuai <yukuai3@huawei.com>
Cc: bp@alien8.de, mchehab@kernel.org, james.morse@arm.com,
rrichter@marvell.com, zhengbin13@huawei.com, yi.zhang@huawei.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: remove set but not used variable 'ecc_loc'
Date: Fri, 13 Dec 2019 15:11:17 -0800 [thread overview]
Message-ID: <20191213231117.GA793@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20191213121036.8886-1-yukuai3@huawei.com>
On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote:
> @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
> pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
> syndrome = dw2;
> pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
> - ecc_loc = i5100_redmemb_ecc_locator(dw2);
> }
>
> if (i5100_validlog_recmemvalid(dw)) {
This deletes the only call to i5100_redmemb_ecc_locator(). Should
we delete the definition of the function too?
Is it worth making cosmetic cleanups to a driver for 12 year old h/w?
-Tony
next prev parent reply other threads:[~2019-12-13 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 12:10 [PATCH] EDAC: remove set but not used variable 'ecc_loc' yu kuai
2019-12-13 23:11 ` Luck, Tony [this message]
2019-12-16 1:11 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213231117.GA793@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).