Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* FAILED: patch "[PATCH] EDAC/altera: Use fast register IO for S10 IRQs" failed to apply to 4.19-stable tree
@ 2019-12-15 10:53 gregkh
  2019-12-15 18:27 ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2019-12-15 10:53 UTC (permalink / raw)
  To: Meng.Li, bp, james.morse, linux-edac, mchehab, rrichter, stable,
	thor.thayer, tony.luck
  Cc: stable


The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 56d9e7bd3fa0f105b6670021d167744bc50ae4fe Mon Sep 17 00:00:00 2001
From: Meng Li <Meng.Li@windriver.com>
Date: Thu, 21 Nov 2019 12:30:46 -0600
Subject: [PATCH] EDAC/altera: Use fast register IO for S10 IRQs

When an IRQ occurs, regmap_{read,write,...}() is invoked in atomic
context. Regmap must indicate register IO is fast so that a spinlock is
used instead of a mutex to avoid sleeping in atomic context:

  lock_acquire
  __mutex_lock
  mutex_lock_nested
  regmap_lock_mutex
  regmap_write
  a10_eccmgr_irq_unmask
  unmask_irq.part.0
  irq_enable
  __irq_startup
  irq_startup
  __setup_irq
  request_threaded_irq
  devm_request_threaded_irq
  altr_sdram_probe

Mark it so.

 [ bp: Massage. ]

Fixes: 3dab6bd52687 ("EDAC, altera: Add support for Stratix10 SDRAM EDAC")
Reported-by: Meng Li <Meng.Li@windriver.com>
Signed-off-by: Meng Li <Meng.Li@windriver.com>
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: James Morse <james.morse@arm.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Robert Richter <rrichter@marvell.com>
Cc: stable <stable@vger.kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/1574361048-17572-2-git-send-email-thor.thayer@linux.intel.com

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index fbda4b876afd..0be3d1b17f03 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -560,6 +560,7 @@ static const struct regmap_config s10_sdram_regmap_cfg = {
 	.reg_write = s10_protected_reg_write,
 	.use_single_read = true,
 	.use_single_write = true,
+	.fast_io = true,
 };
 
 /************** </Stratix10 EDAC Memory Controller Functions> ***********/


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: FAILED: patch "[PATCH] EDAC/altera: Use fast register IO for S10 IRQs" failed to apply to 4.19-stable tree
  2019-12-15 10:53 FAILED: patch "[PATCH] EDAC/altera: Use fast register IO for S10 IRQs" failed to apply to 4.19-stable tree gregkh
@ 2019-12-15 18:27 ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2019-12-15 18:27 UTC (permalink / raw)
  To: gregkh
  Cc: Meng.Li, bp, james.morse, linux-edac, mchehab, rrichter, stable,
	thor.thayer, tony.luck

On Sun, Dec 15, 2019 at 11:53:16AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 56d9e7bd3fa0f105b6670021d167744bc50ae4fe Mon Sep 17 00:00:00 2001
>From: Meng Li <Meng.Li@windriver.com>
>Date: Thu, 21 Nov 2019 12:30:46 -0600
>Subject: [PATCH] EDAC/altera: Use fast register IO for S10 IRQs
>
>When an IRQ occurs, regmap_{read,write,...}() is invoked in atomic
>context. Regmap must indicate register IO is fast so that a spinlock is
>used instead of a mutex to avoid sleeping in atomic context:
>
>  lock_acquire
>  __mutex_lock
>  mutex_lock_nested
>  regmap_lock_mutex
>  regmap_write
>  a10_eccmgr_irq_unmask
>  unmask_irq.part.0
>  irq_enable
>  __irq_startup
>  irq_startup
>  __setup_irq
>  request_threaded_irq
>  devm_request_threaded_irq
>  altr_sdram_probe
>
>Mark it so.
>
> [ bp: Massage. ]
>
>Fixes: 3dab6bd52687 ("EDAC, altera: Add support for Stratix10 SDRAM EDAC")
>Reported-by: Meng Li <Meng.Li@windriver.com>
>Signed-off-by: Meng Li <Meng.Li@windriver.com>
>Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>Signed-off-by: Borislav Petkov <bp@suse.de>
>Cc: James Morse <james.morse@arm.com>
>Cc: linux-edac <linux-edac@vger.kernel.org>
>Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
>Cc: Robert Richter <rrichter@marvell.com>
>Cc: stable <stable@vger.kernel.org>
>Cc: Tony Luck <tony.luck@intel.com>
>Link: https://lkml.kernel.org/r/1574361048-17572-2-git-send-email-thor.thayer@linux.intel.com

Adjusted context and queued for 4.19.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-15 10:53 FAILED: patch "[PATCH] EDAC/altera: Use fast register IO for S10 IRQs" failed to apply to 4.19-stable tree gregkh
2019-12-15 18:27 ` Sasha Levin

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git