Linux-EDAC Archive on
 help / color / Atom feed
From: Borislav Petkov <>
To: Shiping Ji <>
Cc: James Morse <>,,,, LKML <>,,
	Mauro Carvalho Chehab <>,,,
	Lei Wang <>,,,
	Scott Branden <>,
	Yuqing Shen <>,,
Subject: Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt
Date: Fri, 17 Jan 2020 00:39:39 +0100
Message-ID: <20200116233939.GI27148@zn.tnic> (raw)
In-Reply-To: <>

On Wed, Jan 15, 2020 at 06:32:27AM -0800, Shiping Ji wrote:
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
> Signed-off-by: Shiping Ji <>
> Signed-off-by: Lei Wang <>
> Reviewed-by: James Morse <>

So for this patch, v2 had Rui Zhao as an author:

v3 got Lei as an author:

and now it is you.

So when you send next time, think about who's going to be the author.

> +     line numbers. The valid interrupt names are the followings:

WARNING: 'followings' may be misspelled - perhaps 'following'?
#51: FILE: Documentation/devicetree/bindings/edac/arm-dmc520.txt:10:
+     line numbers. The valid interrupt names are the followings:

Please integrate scripts/ into your patch creation
workflow. Some of the warnings/errors *actually* make sense.

Also, this patch throws this other checkpatch warning:

WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst

but since Rob reviewed it, I'm going to assume checkpatch is wrong here.



  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 14:32 Shiping Ji
2020-01-15 20:16 ` Rob Herring
2020-01-16 23:39 ` Borislav Petkov [this message]
2020-01-17  0:05   ` Shiping Ji
2020-01-21 17:53   ` Rob Herring
2020-01-21 17:56     ` Shiping Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116233939.GI27148@zn.tnic \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on

Archives are clonable:
	git clone --mirror linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ \
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone