From: Borislav Petkov <bp@alien8.de>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Yash Shah <yash.shah@sifive.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-edac@vger.kernel.org, linux-riscv@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] EDAC/sifive: fix return value check in ecc_register()
Date: Fri, 17 Jan 2020 01:35:23 +0100 [thread overview]
Message-ID: <20200117003523.GK27148@zn.tnic> (raw)
In-Reply-To: <20200115150303.112627-1-weiyongjun1@huawei.com>
On Wed, Jan 15, 2020 at 03:03:03PM +0000, Wei Yongjun wrote:
> In case of error, the function edac_device_alloc_ctl_info() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: 91abaeaaff35 ("EDAC/sifive: Add EDAC platform driver for SiFive SoCs")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/edac/sifive_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/sifive_edac.c b/drivers/edac/sifive_edac.c
> index c0cc72a3b2be..3a3dcb14ed99 100644
> --- a/drivers/edac/sifive_edac.c
> +++ b/drivers/edac/sifive_edac.c
> @@ -54,8 +54,8 @@ static int ecc_register(struct platform_device *pdev)
> p->dci = edac_device_alloc_ctl_info(0, "sifive_ecc", 1, "sifive_ecc",
> 1, 1, NULL, 0,
> edac_device_alloc_index());
> - if (IS_ERR(p->dci))
> - return PTR_ERR(p->dci);
> + if (!p->dci)
> + return -ENOMEM;
>
> p->dci->dev = &pdev->dev;
> p->dci->mod_name = "Sifive ECC Manager";
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-01-17 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:03 [PATCH] EDAC/sifive: fix return value check in ecc_register() Wei Yongjun
2020-01-17 0:35 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117003523.GK27148@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=weiyongjun1@huawei.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).