From: Robert Richter <rrichter@marvell.com>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: "bp@alien8.de" <bp@alien8.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"manish.narani@xilinx.com" <manish.narani@xilinx.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Frank Li <frank.li@nxp.com>
Subject: Re: [patch v3 3/4] EDAC: synopsys: Add edac driver support for i.MX8MP
Date: Wed, 8 Apr 2020 08:40:21 +0200 [thread overview]
Message-ID: <20200408064020.fjg55j7vvcvsqxgb@rric.localdomain> (raw)
In-Reply-To: <VI1PR04MB4960DF2EF1961DCF74655BF592C60@VI1PR04MB4960.eurprd04.prod.outlook.com>
On 02.04.20 13:09:57, Sherry Sun wrote:
> > From: Robert Richter <rrichter@marvell.com>
> > On 02.04.20 09:06:27, Sherry Sun wrote:
> > > > From: Robert Richter <rrichter@marvell.com> On 02.04.20 09:20:32,
> > > > > +/* Interrupt Handler for ECC interrupts on imx8mp platform. */
> > > > > +static irqreturn_t intr_handler_imx8mp(int irq, void *dev_id) {
> > > > > + const struct synps_platform_data *p_data;
> > > > > + struct mem_ctl_info *mci = dev_id;
> > > > > + struct synps_edac_priv *priv;
> > > > > + int status, regval;
> > > > > +
> > > > > + priv = mci->pvt_info;
> > > > > + p_data = priv->p_data;
> > > > > +
> > > > > + regval = readl(priv->baseaddr + ECC_STAT_OFST);
> > > > > + if (!(regval & ECC_INTR_MASK))
> > > > > + return IRQ_NONE;
> > > > > +
> > > > > + status = p_data->get_error_info(priv);
> > > > > + if (status)
> > > > > + return IRQ_NONE;
> > > > > +
> > > > > + priv->ce_cnt += priv->stat.ce_cnt;
> > > > > + priv->ue_cnt += priv->stat.ue_cnt;
> > > > > + handle_error(mci, &priv->stat);
> > > > > +
> > > > > + edac_dbg(3, "Total error count CE %d UE %d\n",
> > > > > + priv->ce_cnt, priv->ue_cnt);
> > > > > + enable_intr_imx8mp(priv);
> > > >
> > > > Why do you enable interrupts here?
> > >
> > > Because zynqmp_get_error_info() wrote 0 to ECC_CLR_OFST, so here have
> > to re-enable the interrupts.
> >
> > This does not seem to be the right place for it.
> >
> > > As said in the commit, the main difference between ZynqMP and i.MX8MP
> > ddr controller is the interrupt registers.
> > > ZynqMP use DDR QOS Interrupt registers, but i.MX8MP use ECC_CLR_OFST
> > Register(bit8 and bit9) to enable/disable the ce/ue interrupts.
> > >
> > > In zynqmp_get_error_info(), Zynqmp wrote 0 to ECC_CLR_OFST register to
> > clear CE/UE error flags and counts, it has no effect on Zynqmp interrupts.
> > > But for i.MX8MP, wirte 0 to ECC_CLR_OFST will disable i.MX8MP CE/UE
> > interrupt, so need re-enable the interrupts.
> >
> > All this shows one more time there should be separate handlers. You should
> > get rid most callbacks in struct synps_platform_data and instead have
> > separate probe functions for both flavors that share common code.
>
> Do you mean that I should create specific callbacks in struct synps_platform_data for i.MX8MP instead reuse the ZynqMP functions?
> But except this operation of write 0 to ECC_CLR_OFST in zynqmp_get_error_info(),
> the other callbacks in struct synps_platform_data are all the same between ZynqMP and i.MX8MP.
Most callbacks in struct synps_platform_data will become obsolete if
there are either device tailored functions or if the width parameter
would be stored in private data and used by a common function.
-Robert
next prev parent reply other threads:[~2020-04-08 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 1:20 [patch v3 0/4] Add edac driver for i.MX8MP based on synopsys edac driver Sherry Sun
2020-04-02 1:20 ` [patch v3 1/4] dt-bindings: memory-controllers: Add i.MX8MP DDRC binding doc Sherry Sun
2020-04-02 1:20 ` [patch v3 2/4] EDAC: Add synopsys edac driver support for i.MX8MP Sherry Sun
2020-04-02 1:20 ` [patch v3 3/4] EDAC: synopsys: Add " Sherry Sun
2020-04-02 7:22 ` Robert Richter
2020-04-02 9:06 ` Sherry Sun
2020-04-02 11:17 ` Robert Richter
2020-04-02 13:09 ` Sherry Sun
2020-04-08 6:40 ` Robert Richter [this message]
2020-04-02 1:20 ` [patch v3 4/4] EDAC: synopsys: Add useful debug and output information for 64bit systems Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408064020.fjg55j7vvcvsqxgb@rric.localdomain \
--to=rrichter@marvell.com \
--cc=bp@alien8.de \
--cc=frank.li@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=sherry.sun@nxp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).