Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] EDAC/armada_xp: Fix some log messages
@ 2020-04-13  4:15 Christophe JAILLET
  2020-04-14  8:23 ` Jan Lübbe
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Christophe JAILLET @ 2020-04-13  4:15 UTC (permalink / raw)
  To: jlu, bp, mchehab, tony.luck, james.morse, rrichter
  Cc: linux-edac, linux-kernel, kernel-janitors, Christophe JAILLET

Fix some spelling (s/Aramda/Armada/) in 1 log message and in 1 comment.

While at it, add some trailing '\n' in some other log message.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/edac/armada_xp_edac.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c
index a7502ebe9bdc..e3e757513d1b 100644
--- a/drivers/edac/armada_xp_edac.c
+++ b/drivers/edac/armada_xp_edac.c
@@ -78,7 +78,7 @@ struct axp_mc_drvdata {
 	char msg[128];
 };
 
-/* derived from "DRAM Address Multiplexing" in the ARAMDA XP Functional Spec */
+/* derived from "DRAM Address Multiplexing" in the ARMADA XP Functional Spec */
 static uint32_t axp_mc_calc_address(struct axp_mc_drvdata *drvdata,
 				    uint8_t cs, uint8_t bank, uint16_t row,
 				    uint16_t col)
@@ -160,12 +160,12 @@ static void axp_mc_check(struct mem_ctl_info *mci)
 		if (cnt_sbe)
 			cnt_sbe--;
 		else
-			dev_warn(mci->pdev, "inconsistent SBE count detected");
+			dev_warn(mci->pdev, "inconsistent SBE count detected\n");
 	} else {
 		if (cnt_dbe)
 			cnt_dbe--;
 		else
-			dev_warn(mci->pdev, "inconsistent DBE count detected");
+			dev_warn(mci->pdev, "inconsistent DBE count detected\n");
 	}
 
 	/* report earlier errors */
@@ -304,7 +304,7 @@ static int axp_mc_probe(struct platform_device *pdev)
 
 	config = readl(base + SDRAM_CONFIG_REG);
 	if (!(config & SDRAM_CONFIG_ECC_MASK)) {
-		dev_warn(&pdev->dev, "SDRAM ECC is not enabled");
+		dev_warn(&pdev->dev, "SDRAM ECC is not enabled\n");
 		return -EINVAL;
 	}
 
@@ -532,9 +532,9 @@ static int aurora_l2_probe(struct platform_device *pdev)
 
 	l2x0_aux_ctrl = readl(base + L2X0_AUX_CTRL);
 	if (!(l2x0_aux_ctrl & AURORA_ACR_PARITY_EN))
-		dev_warn(&pdev->dev, "tag parity is not enabled");
+		dev_warn(&pdev->dev, "tag parity is not enabled\n");
 	if (!(l2x0_aux_ctrl & AURORA_ACR_ECC_EN))
-		dev_warn(&pdev->dev, "data ECC is not enabled");
+		dev_warn(&pdev->dev, "data ECC is not enabled\n");
 
 	dci = edac_device_alloc_ctl_info(sizeof(*drvdata),
 					 "cpu", 1, "L", 1, 2, NULL, 0, 0);
@@ -618,7 +618,7 @@ static int __init armada_xp_edac_init(void)
 
 	res = platform_register_drivers(drivers, ARRAY_SIZE(drivers));
 	if (res)
-		pr_warn("Aramda XP EDAC drivers fail to register\n");
+		pr_warn("Armada XP EDAC drivers fail to register\n");
 
 	return 0;
 }
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC/armada_xp: Fix some log messages
  2020-04-13  4:15 [PATCH] EDAC/armada_xp: Fix some log messages Christophe JAILLET
@ 2020-04-14  8:23 ` Jan Lübbe
  2020-04-14  9:46 ` Robert Richter
  2020-04-14  9:47 ` Borislav Petkov
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Lübbe @ 2020-04-14  8:23 UTC (permalink / raw)
  To: Christophe JAILLET, bp, mchehab, tony.luck, james.morse, rrichter
  Cc: linux-edac, linux-kernel, kernel-janitors

On Mon, 2020-04-13 at 06:15 +0200, Christophe JAILLET wrote:
> Fix some spelling (s/Aramda/Armada/) in 1 log message and in 1
> comment.
> 
> While at it, add some trailing '\n' in some other log message.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Jan Luebbe <jlu@pengutronix.de>

Thanks,

Jan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC/armada_xp: Fix some log messages
  2020-04-13  4:15 [PATCH] EDAC/armada_xp: Fix some log messages Christophe JAILLET
  2020-04-14  8:23 ` Jan Lübbe
@ 2020-04-14  9:46 ` Robert Richter
  2020-04-14  9:47 ` Borislav Petkov
  2 siblings, 0 replies; 4+ messages in thread
From: Robert Richter @ 2020-04-14  9:46 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: jlu, bp, mchehab, tony.luck, james.morse, linux-edac,
	linux-kernel, kernel-janitors

On 13.04.20 06:15:56, Christophe JAILLET wrote:
> Fix some spelling (s/Aramda/Armada/) in 1 log message and in 1 comment.
> 
> While at it, add some trailing '\n' in some other log message.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Robert Richter <rrichter@marvell.com>

> ---
>  drivers/edac/armada_xp_edac.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Note there are some other "Aramda" occurrences in the kernel:

linux/master:Documentation/devicetree/bindings/rtc/armada-380-rtc.txt:  "marvell,armada-8k-rtc" for Aramda 7K/8K SoCs
linux/master:arch/arm64/boot/dts/marvell/armada-8020.dtsi:/* The RTC requires external oscillator. But on Aramda 80x0, the RTC clock
linux/master:arch/arm64/boot/dts/marvell/armada-8040.dtsi:/* The RTC requires external oscillator. But on Aramda 80x0, the RTC clock
linux/master:drivers/mtd/nand/raw/Kconfig:        - 64-bit Aramda platforms (7k, 8k) (NFCv2)

Thanks,

-Robert

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC/armada_xp: Fix some log messages
  2020-04-13  4:15 [PATCH] EDAC/armada_xp: Fix some log messages Christophe JAILLET
  2020-04-14  8:23 ` Jan Lübbe
  2020-04-14  9:46 ` Robert Richter
@ 2020-04-14  9:47 ` Borislav Petkov
  2 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2020-04-14  9:47 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: jlu, mchehab, tony.luck, james.morse, rrichter, linux-edac,
	linux-kernel, kernel-janitors

On Mon, Apr 13, 2020 at 06:15:56AM +0200, Christophe JAILLET wrote:
> Fix some spelling (s/Aramda/Armada/) in 1 log message and in 1 comment.
> 
> While at it, add some trailing '\n' in some other log message.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/edac/armada_xp_edac.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13  4:15 [PATCH] EDAC/armada_xp: Fix some log messages Christophe JAILLET
2020-04-14  8:23 ` Jan Lübbe
2020-04-14  9:46 ` Robert Richter
2020-04-14  9:47 ` Borislav Petkov

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git