Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS
@ 2020-04-13 11:52 Lukas Bulwahn
  2020-04-15  9:34 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2020-04-13 11:52 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: Christoph Hellwig, Borislav Petkov, Yash Shah, linux-edac,
	Sebastian Duda, Joe Perches, kernel-janitors, linux-kernel,
	Lukas Bulwahn

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

  warning: no file matches F: drivers/soc/sifive_l2_cache.c

Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE
DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and
by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part
of the SIFIVE DRIVERS.

Suggested-by: Borislav Petkov <bp@alien8.de>
Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
  - was not picked up.

v1-resend: https://lore.kernel.org/lkml/20200413073447.9284-1-lukas.bulwahn@gmail.com/

v2: https://lore.kernel.org/lkml/20200413114702.6372-1-lukas.bulwahn@gmail.com/
 - reworked based on Boris comment

v3: v2 was broken, I forgot to commit the actual change. Now properly reworked.


 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e64e5db31497..63839a920e1b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6172,7 +6172,6 @@ M:	Yash Shah <yash.shah@sifive.com>
 L:	linux-edac@vger.kernel.org
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
 
 EDAC-SKYLAKE
 M:	Tony Luck <tony.luck@intel.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS
  2020-04-13 11:52 [PATCH v3] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS Lukas Bulwahn
@ 2020-04-15  9:34 ` Borislav Petkov
  0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2020-04-15  9:34 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Paul Walmsley, Christoph Hellwig, Borislav Petkov, Yash Shah,
	linux-edac, Sebastian Duda, Joe Perches, kernel-janitors,
	linux-kernel

On Mon, Apr 13, 2020 at 01:52:55PM +0200, Lukas Bulwahn wrote:
> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: drivers/soc/sifive_l2_cache.c
> 
> Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE
> DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and
> by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part
> of the SIFIVE DRIVERS.
> 
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 11:52 [PATCH v3] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS Lukas Bulwahn
2020-04-15  9:34 ` Borislav Petkov

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git