From: kbuild test robot <lkp@intel.com> To: Robert Richter <rrichter@marvell.com>, Borislav Petkov <bp@alien8.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Tony Luck <tony.luck@intel.com> Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org, James Morse <james.morse@arm.com>, Aristeu Rozanski <aris@redhat.com>, Robert Richter <rrichter@marvell.com>, Matthias Brugger <mbrugger@suse.com>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/10] EDAC/ghes: Make SMBIOS handle private data to ghes Date: Fri, 24 Apr 2020 20:12:02 +0800 Message-ID: <202004242006.ngMbwLSz%lkp@intel.com> (raw) In-Reply-To: <20200422115814.22205-5-rrichter@marvell.com> [-- Attachment #1: Type: text/plain, Size: 5544 bytes --] Hi Robert, I love your patch! Yet something to improve: [auto build test ERROR on ras/edac-for-next] [also build test ERROR on linus/master v5.7-rc2 next-20200423] [cannot apply to bp/for-next linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Robert-Richter/EDAC-mc-ghes-Fixes-cleanup-and-reworks/20200424-042828 base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): In file included from arch/x86/include/asm/bug.h:83:0, from include/linux/bug.h:5, from include/linux/debug_locks.h:7, from include/linux/lockdep.h:44, from include/linux/spinlock_types.h:18, from include/linux/mutex.h:16, from include/linux/kernfs.h:12, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/acpi/apei.h:9, from include/acpi/ghes.h:5, from drivers/edac/ghes_edac.c:12: drivers/edac/ghes_edac.c: In function 'ghes_dimm_pool_create': >> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex') #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) ^ include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held' WARN_ON(debug_locks && !lockdep_is_held(l)); \ ^~~~~~~~~~~~~~~ >> drivers/edac/ghes_edac.c:104:2: note: in expansion of macro 'lockdep_assert_held' lockdep_assert_held(ghes_reg_mutex); ^~~~~~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c: In function 'ghes_dimm_pool_destroy': >> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex') #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) ^ include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held' WARN_ON(debug_locks && !lockdep_is_held(l)); \ ^~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c:118:2: note: in expansion of macro 'lockdep_assert_held' lockdep_assert_held(ghes_reg_mutex); ^~~~~~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c: In function 'ghes_dimm_alloc': >> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex') #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) ^ include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held' WARN_ON(debug_locks && !lockdep_is_held(l)); \ ^~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c:127:2: note: in expansion of macro 'lockdep_assert_held' lockdep_assert_held(ghes_reg_mutex); ^~~~~~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c: In function 'ghes_dimm_release': >> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex') #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) ^ include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held' WARN_ON(debug_locks && !lockdep_is_held(l)); \ ^~~~~~~~~~~~~~~ drivers/edac/ghes_edac.c:144:2: note: in expansion of macro 'lockdep_assert_held' lockdep_assert_held(ghes_reg_mutex); ^~~~~~~~~~~~~~~~~~~ vim +/lockdep_assert_held +104 drivers/edac/ghes_edac.c 96 97 static int ghes_dimm_pool_create(int num_dimm) 98 { 99 struct ghes_dimm *ghes_dimm; 100 101 if (!num_dimm) 102 return 0; 103 > 104 lockdep_assert_held(ghes_reg_mutex); 105 106 dimms = kcalloc(num_dimm, sizeof(*dimms), GFP_KERNEL); 107 if (!dimms) 108 return -ENOMEM; 109 110 for (ghes_dimm = dimms; ghes_dimm < dimms + num_dimm; ghes_dimm++) 111 list_add(&ghes_dimm->entry, &ghes_dimm_pool); 112 113 return 0; 114 } 115 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 72268 bytes --]
next prev parent reply index Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-22 11:58 [PATCH v2 00/10] EDAC/mc/ghes: Fixes, cleanup and reworks Robert Richter 2020-04-22 11:58 ` [PATCH v2 01/10] EDAC/mc: Fix usage of snprintf() and dimm location setup Robert Richter 2020-04-22 20:52 ` Borislav Petkov 2020-05-19 9:27 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 02/10] EDAC/mc: Use int type for parameters of edac_mc_alloc() Robert Richter 2020-04-23 17:49 ` Borislav Petkov 2020-05-19 9:33 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 03/10] EDAC/ghes: Remove unused members of struct ghes_edac_pvt, rename it to ghes_mci Robert Richter 2020-04-23 17:55 ` Borislav Petkov 2020-05-05 7:50 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 04/10] EDAC/ghes: Make SMBIOS handle private data to ghes Robert Richter 2020-04-24 12:12 ` kbuild test robot [this message] 2020-04-24 16:21 ` Borislav Petkov 2020-05-05 12:48 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 05/10] EDAC/ghes: Setup DIMM label from DMI and use it in error reports Robert Richter 2020-04-22 11:58 ` [PATCH v2 06/10] EDAC/ghes: Remove local variable rdr_mask in ghes_edac_dmidecode() Robert Richter 2020-04-27 7:08 ` Borislav Petkov 2020-04-27 17:24 ` Luck, Tony 2020-04-27 17:34 ` Borislav Petkov 2020-05-19 9:34 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 07/10] EDAC/ghes: Cleanup struct ghes_edac_dimm_fill, rename it to ghes_dimm_fill Robert Richter 2020-04-27 14:00 ` Borislav Petkov 2020-05-19 9:35 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 08/10] EDAC/ghes: Carve out MC device handling into separate functions Robert Richter 2020-04-27 16:38 ` Borislav Petkov 2020-05-06 8:45 ` Robert Richter 2020-05-11 13:32 ` Borislav Petkov 2020-05-19 9:57 ` Robert Richter 2020-04-22 11:58 ` [PATCH v2 09/10] EDAC/ghes: Have a separate code path for creating the fake MC Robert Richter 2020-04-22 11:58 ` [PATCH v2 10/10] EDAC/ghes: Carve out code into ghes_edac_register_{one,fake}() Robert Richter 2020-05-06 8:53 ` [PATCH v2 00/10] EDAC/mc/ghes: Fixes, cleanup and reworks Robert Richter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202004242006.ngMbwLSz%lkp@intel.com \ --to=lkp@intel.com \ --cc=aris@redhat.com \ --cc=bp@alien8.de \ --cc=james.morse@arm.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mbrugger@suse.com \ --cc=mchehab@kernel.org \ --cc=rrichter@marvell.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-EDAC Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \ linux-edac@vger.kernel.org public-inbox-index linux-edac Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac AGPL code for this site: git clone https://public-inbox.org/public-inbox.git