linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Waiman Long <longman@redhat.com>
Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rrichter@marvell.com>,
	linux-edac@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: Fix some typo errors in ras.rst
Date: Tue, 5 May 2020 09:32:58 -0600	[thread overview]
Message-ID: <20200505093258.77d052f5@lwn.net> (raw)
In-Reply-To: <20200505151049.11134-1-longman@redhat.com>

On Tue,  5 May 2020 11:10:49 -0400
Waiman Long <longman@redhat.com> wrote:

> Fix typo errors.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>  Documentation/admin-guide/ras.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/ras.rst b/Documentation/admin-guide/ras.rst
> index 0310db624964..8b1803b2606f 100644
> --- a/Documentation/admin-guide/ras.rst
> +++ b/Documentation/admin-guide/ras.rst
> @@ -156,10 +156,10 @@ the labels provided by the BIOS won't match the real ones.
>  ECC memory
>  ----------
>  
> -As mentioned on the previous section, ECC memory has extra bits to be
> -used for error correction. So, on 64 bit systems, a memory module
> -has 64 bits of *data width*, and 74 bits of *total width*. So, there are
> -8 bits extra bits to be used for the error detection and correction
> +As mentioned on the previous section, ECC memory has extra bits to
> +be used for error correction. So, on 64 bit systems, a memory module
> +has 64 bits of *data width*, and 72 bits of *total width*. So, there
> +are 8 extra bits to be used for the error detection and correction
>  mechanisms. Those extra bits are called *syndrome*\ [#f1]_\ [#f2]_.

So I had to work to figure out what the change was, since you didn't say
in the changelog and you refilled the paragraph.  But this looks like a
*factual* error, giving the wrong number of bits, right?  It seems like
the changelog should say that.  Do the people who know about this stuff
agree that the change is correct?

Thanks,

jon

  reply	other threads:[~2020-05-05 15:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 15:10 [PATCH] doc: Fix some typo errors in ras.rst Waiman Long
2020-05-05 15:32 ` Jonathan Corbet [this message]
2020-05-05 15:50   ` Waiman Long
2020-05-05 15:48 ` Matthew Wilcox
2020-05-05 16:03   ` Borislav Petkov
2020-05-06 16:21     ` Waiman Long
2020-05-06 16:19   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505093258.77d052f5@lwn.net \
    --to=corbet@lwn.net \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mchehab@kernel.org \
    --cc=rrichter@marvell.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).