From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3438AC47259 for ; Tue, 5 May 2020 15:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FB0B20836 for ; Tue, 5 May 2020 15:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730004AbgEEPdF (ORCPT ); Tue, 5 May 2020 11:33:05 -0400 Received: from ms.lwn.net ([45.79.88.28]:50126 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730294AbgEEPdA (ORCPT ); Tue, 5 May 2020 11:33:00 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id D6C1331A; Tue, 5 May 2020 15:32:59 +0000 (UTC) Date: Tue, 5 May 2020 09:32:58 -0600 From: Jonathan Corbet To: Waiman Long Cc: Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , James Morse , Robert Richter , linux-edac@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: Fix some typo errors in ras.rst Message-ID: <20200505093258.77d052f5@lwn.net> In-Reply-To: <20200505151049.11134-1-longman@redhat.com> References: <20200505151049.11134-1-longman@redhat.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, 5 May 2020 11:10:49 -0400 Waiman Long wrote: > Fix typo errors. > > Signed-off-by: Waiman Long > --- > Documentation/admin-guide/ras.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/admin-guide/ras.rst b/Documentation/admin-guide/ras.rst > index 0310db624964..8b1803b2606f 100644 > --- a/Documentation/admin-guide/ras.rst > +++ b/Documentation/admin-guide/ras.rst > @@ -156,10 +156,10 @@ the labels provided by the BIOS won't match the real ones. > ECC memory > ---------- > > -As mentioned on the previous section, ECC memory has extra bits to be > -used for error correction. So, on 64 bit systems, a memory module > -has 64 bits of *data width*, and 74 bits of *total width*. So, there are > -8 bits extra bits to be used for the error detection and correction > +As mentioned on the previous section, ECC memory has extra bits to > +be used for error correction. So, on 64 bit systems, a memory module > +has 64 bits of *data width*, and 72 bits of *total width*. So, there > +are 8 extra bits to be used for the error detection and correction > mechanisms. Those extra bits are called *syndrome*\ [#f1]_\ [#f2]_. So I had to work to figure out what the change was, since you didn't say in the changelog and you refilled the paragraph. But this looks like a *factual* error, giving the wrong number of bits, right? It seems like the changelog should say that. Do the people who know about this stuff agree that the change is correct? Thanks, jon