Linux-EDAC Archive on
 help / color / Atom feed
* [PATCH] edac: Fix reference count leak in edac_pci_main_kobj_setup.
@ 2020-05-28 20:22 wu000273
  2020-06-17 13:56 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: wu000273 @ 2020-05-28 20:22 UTC (permalink / raw)
  To: kjlu
  Cc: wu000273, Borislav Petkov, Mauro Carvalho Chehab, Tony Luck,
	James Morse, Robert Richter, Greg Kroah-Hartman, Doug Thompson,
	linux-edac, linux-kernel

From: Qiushi Wu <>

kobject_init_and_add() should be handled when it return an error,
because kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem. Thus replace calling
kfree() by calling kobject_put().

Fixes: b2ed215a3338 ("Kobject: change drivers/edac to use kobject_init_and_add")
Signed-off-by: Qiushi Wu <>
 drivers/edac/edac_pci_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/edac_pci_sysfs.c b/drivers/edac/edac_pci_sysfs.c
index 72c9eb9fdffb..53042af7262e 100644
--- a/drivers/edac/edac_pci_sysfs.c
+++ b/drivers/edac/edac_pci_sysfs.c
@@ -386,7 +386,7 @@ static int edac_pci_main_kobj_setup(void)
 	/* Error unwind statck */
-	kfree(edac_pci_top_main_kobj);
+	kobject_put(edac_pci_top_main_kobj);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 20:22 [PATCH] edac: Fix reference count leak in edac_pci_main_kobj_setup wu000273
2020-06-17 13:56 ` Borislav Petkov

Linux-EDAC Archive on

Archives are clonable:
	git clone --mirror linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ \
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone