* [PATCH] EDAC: remove redundant assignment to variable ret
@ 2020-04-29 15:48 Colin King
2020-05-29 13:20 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-04-29 15:48 UTC (permalink / raw)
To: Borislav Petkov, Mauro Carvalho Chehab, Tony Luck, James Morse,
Robert Richter, linux-edac
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being assigned with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/edac/amd64_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 6bdc5bb8c8bc..e33f66cee132 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3400,7 +3400,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = {
static int hw_info_get(struct amd64_pvt *pvt)
{
u16 pci_id1, pci_id2;
- int ret = -EINVAL;
+ int ret;
if (pvt->fam >= 0x17) {
pvt->umc = kcalloc(fam_type->max_mcs, sizeof(struct amd64_umc), GFP_KERNEL);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC: remove redundant assignment to variable ret
2020-04-29 15:48 [PATCH] EDAC: remove redundant assignment to variable ret Colin King
@ 2020-05-29 13:20 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2020-05-29 13:20 UTC (permalink / raw)
To: Colin King
Cc: Mauro Carvalho Chehab, Tony Luck, James Morse, Robert Richter,
linux-edac, kernel-janitors, linux-kernel
On Wed, Apr 29, 2020 at 04:48:47PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable ret is being assigned with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/amd64_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 6bdc5bb8c8bc..e33f66cee132 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3400,7 +3400,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = {
> static int hw_info_get(struct amd64_pvt *pvt)
> {
> u16 pci_id1, pci_id2;
> - int ret = -EINVAL;
> + int ret;
>
> if (pvt->fam >= 0x17) {
> pvt->umc = kcalloc(fam_type->max_mcs, sizeof(struct amd64_umc), GFP_KERNEL);
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-29 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 15:48 [PATCH] EDAC: remove redundant assignment to variable ret Colin King
2020-05-29 13:20 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).