From: Robert Richter <rrichter@marvell.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<tony.luck@intel.com>, <bp@alien8.de>, <mchehab@kernel.org>,
<james.morse@arm.com>
Subject: Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled
Date: Wed, 10 Jun 2020 12:18:19 +0200 [thread overview]
Message-ID: <20200610101819.oa2ivjtxildwothl@rric.localdomain> (raw)
In-Reply-To: <20200610065801.3579-1-zhenzhong.duan@gmail.com>
On 10.06.20 14:58:01, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Reviewed-by: Robert Richter <rrichter@marvell.com>
> ---
> drivers/edac/skx_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>
> skx_mce_output_error(mci, mce, &res);
>
> - return NOTIFY_DONE;
> + /* Advice mcelog that the error were handled */
... error was ...
And make a sentence out of it, so close with a dot.
> + return NOTIFY_STOP;
This change aligns with other implementation in:
i7core_mce_check_error(),
amd_decode_mce() and
sbridge_mce_check_error().
-Robert
> }
>
> void skx_remove(void)
> --
> 1.8.3.1
>
prev parent reply other threads:[~2020-06-10 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 6:58 [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled Zhenzhong Duan
2020-06-10 8:20 ` Borislav Petkov
2020-06-10 8:48 ` Zhenzhong Duan
2020-06-10 10:18 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610101819.oa2ivjtxildwothl@rric.localdomain \
--to=rrichter@marvell.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
--cc=zhenzhong.duan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).