Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Robert Richter <rrichter@marvell.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<tony.luck@intel.com>, <bp@alien8.de>, <mchehab@kernel.org>,
	<james.morse@arm.com>
Subject: Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled
Date: Wed, 10 Jun 2020 12:18:19 +0200
Message-ID: <20200610101819.oa2ivjtxildwothl@rric.localdomain> (raw)
In-Reply-To: <20200610065801.3579-1-zhenzhong.duan@gmail.com>

On 10.06.20 14:58:01, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>

Reviewed-by: Robert Richter <rrichter@marvell.com>

> ---
>  drivers/edac/skx_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>  
>  	skx_mce_output_error(mci, mce, &res);
>  
> -	return NOTIFY_DONE;
> +	/* Advice mcelog that the error were handled */

... error was ...

And make a sentence out of it, so close with a dot.

> +	return NOTIFY_STOP;

This change aligns with other implementation in:

 i7core_mce_check_error(),
 amd_decode_mce() and
 sbridge_mce_check_error().

-Robert

>  }
>  
>  void skx_remove(void)
> -- 
> 1.8.3.1
> 

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  6:58 [PATCH] EDAC, {skx,i10nm}: " Zhenzhong Duan
2020-06-10  8:20 ` Borislav Petkov
2020-06-10  8:48   ` Zhenzhong Duan
2020-06-10 10:18 ` Robert Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610101819.oa2ivjtxildwothl@rric.localdomain \
    --to=rrichter@marvell.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=zhenzhong.duan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git