Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	bp@alien8.de, mchehab@kernel.org, james.morse@arm.com,
	rrichter@marvell.com
Subject: Re: [PATCH] EDAC/mc: call edac_inc_ue_error() before panic
Date: Wed, 10 Jun 2020 10:19:12 -0700
Message-ID: <20200610171912.GB1474@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20200610065846.3626-2-zhenzhong.duan@gmail.com>

On Wed, Jun 10, 2020 at 02:58:46PM +0800, Zhenzhong Duan wrote:
> By calling edac_inc_ue_error() before panic, we get a correct UE error
> count for core dump analysis.

Looks accurate, and I'll add the patch to be applied. But I wonder
how big a problem it is. Isn't most of the information deriveable
from the panic message?

> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> ---
>  drivers/edac/edac_mc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 75ede27..c1f23c2 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -1011,6 +1011,8 @@ static void edac_ue_error(struct edac_raw_error_desc *e)
>  			e->other_detail);
>  	}
>  
> +	edac_inc_ue_error(e);
> +
>  	if (edac_mc_get_panic_on_ue()) {
>  		panic("UE %s%son %s (%s page:0x%lx offset:0x%lx grain:%ld%s%s)\n",
>  			e->msg,
> @@ -1020,8 +1022,6 @@ static void edac_ue_error(struct edac_raw_error_desc *e)
>  			*e->other_detail ? " - " : "",
>  			e->other_detail);
>  	}
> -
> -	edac_inc_ue_error(e);
>  }
>  
>  static void edac_inc_csrow(struct edac_raw_error_desc *e, int row, int chan)
> -- 
> 1.8.3.1
> 

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  6:58 [PATCH] EDAC, pnd2: set MCE_PRIO_EDAC priority for pnd2_mce_dec notifier Zhenzhong Duan
2020-06-10  6:58 ` [PATCH] EDAC/mc: call edac_inc_ue_error() before panic Zhenzhong Duan
2020-06-10 17:19   ` Luck, Tony [this message]
2020-06-11  2:37     ` Zhenzhong Duan
2020-06-10 17:16 ` [PATCH] EDAC, pnd2: set MCE_PRIO_EDAC priority for pnd2_mce_dec notifier Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610171912.GB1474@agluck-desk2.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rrichter@marvell.com \
    --cc=zhenzhong.duan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git