Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jacky Hu <hengqing.hu@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	x86@kernel.org, yazen.ghannam@amd.com, bp@alien8.de,
	clemens@ladisch.de
Subject: Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe
Date: Wed, 17 Jun 2020 07:33:42 -0700
Message-ID: <20200617143342.GD93431@roeck-us.net> (raw)
In-Reply-To: <20200617071927.GA398128@i716>

On Wed, Jun 17, 2020 at 03:19:27PM +0800, Jacky Hu wrote:
> Hi Guenter,
> 
> By increasing the regs count from 32 to 256 and looking into the output of `cat /sys/kernel/debug/k10temp-0000\:00\:18.3/svi`
> There is some data from 0x05a300 - 0x05a330
> Do you have any idea how we can guess the offset for this model?
> 

For other chips, the upper 16 bits of the register reported the voltage
and the lower 16 bit reported the current. It might possibly be that the
data is now split into multiple registers, but that is impossible to
determine without datasheet and/or additional information. So, sorry,
no, I have no idea. We'll have to wait for someone to reverse engineer
it.

Can you send the contents of the "thm" file ? Maybe we can at least
find the new location of the ccd temperature registers.

Guenter

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07  4:37 [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Jacky Hu
2020-06-07  4:37 ` [PATCH 1/2] x86/amd_nb: Add Family 17h, Model 60h PCI IDs Jacky Hu
2020-06-16 18:08   ` Borislav Petkov
2020-06-07  4:37 ` [PATCH 2/2] EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh Jacky Hu
2020-06-16 18:09   ` Borislav Petkov
2020-06-17  1:32     ` [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe Jacky Hu
2020-06-17  3:40       ` Guenter Roeck
2020-06-17  7:19         ` Jacky Hu
2020-06-17 14:33           ` Guenter Roeck [this message]
2020-06-17 14:55             ` Jacky Hu
2020-06-17 14:54           ` Alexander Monakov
2020-06-17 15:07             ` Jacky Hu
2020-06-17 15:22               ` Borislav Petkov
2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
2020-06-15 15:01   ` Guenter Roeck
2020-06-16 14:35     ` Borislav Petkov
2020-06-16 14:46       ` Guenter Roeck
2020-06-16 14:55         ` Borislav Petkov
2020-06-16 14:11   ` Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617143342.GD93431@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=hengqing.hu@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git