* [PATCH] x86/mce, edac/mce_amd: Print PPIN in machine check records
@ 2020-06-23 13:00 Smita Koralahalli
2020-06-23 15:30 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Smita Koralahalli @ 2020-06-23 13:00 UTC (permalink / raw)
To: Smita.KoralahalliChannabasappa, Yazen.Ghannam
Cc: Borislav Petkov, Tony Luck, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, Mauro Carvalho Chehab, James Morse,
Robert Richter, Yazen Ghannam, Wei Huang, x86, linux-edac,
linux-kernel
For AMD processors that support Protected Processor Identification
Number (PPIN), the PPIN information is included in machine check records.
If present, print it along with other decoded MCA information.
Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Robert Richter <rrichter@marvell.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Wei Huang <wei.huang2@amd.com>
Cc: x86@kernel.org
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
arch/x86/kernel/cpu/mce/core.c | 2 ++
drivers/edac/mce_amd.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index ce9120c4f740..0865349502d5 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -244,6 +244,8 @@ static void __print_mce(struct mce *m)
pr_cont("ADDR %llx ", m->addr);
if (m->misc)
pr_cont("MISC %llx ", m->misc);
+ if (m->ppin)
+ pr_cont("PPIN %llx ", m->ppin);
if (mce_flags.smca) {
if (m->synd)
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index 2b5401db56ad..325aedf46ff2 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -1094,6 +1094,9 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
if (m->status & MCI_STATUS_ADDRV)
pr_emerg(HW_ERR "Error Addr: 0x%016llx\n", m->addr);
+ if (m->ppin)
+ pr_emerg(HW_ERR "PPIN: 0x%016llx\n", m->ppin);
+
if (boot_cpu_has(X86_FEATURE_SMCA)) {
pr_emerg(HW_ERR "IPID: 0x%016llx", m->ipid);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/mce, edac/mce_amd: Print PPIN in machine check records
2020-06-23 13:00 [PATCH] x86/mce, edac/mce_amd: Print PPIN in machine check records Smita Koralahalli
@ 2020-06-23 15:30 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2020-06-23 15:30 UTC (permalink / raw)
To: Smita Koralahalli
Cc: Yazen.Ghannam, Tony Luck, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, Mauro Carvalho Chehab, James Morse,
Robert Richter, Wei Huang, x86, linux-edac, linux-kernel
On Tue, Jun 23, 2020 at 08:00:59AM -0500, Smita Koralahalli wrote:
> For AMD processors that support Protected Processor Identification
Not only AMD processors - Intel support it too. I've made the commit
message vendor-agnostic.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-23 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 13:00 [PATCH] x86/mce, edac/mce_amd: Print PPIN in machine check records Smita Koralahalli
2020-06-23 15:30 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).