Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
@ 2020-07-14 14:23 Wei Yongjun
  2020-07-27 13:56 ` Robert Richter
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-14 14:23 UTC (permalink / raw)
  To: Hulk Robot, Robert Richter, Borislav Petkov,
	Mauro Carvalho Chehab, Tony Luck
  Cc: Wei Yongjun, linux-edac

The sparse tool complains as follows:

drivers/edac/thunderx_edac.c:457:22: warning:
 symbol 'lmc_dfs_ents' was not declared. Should it be static?

Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/edac/thunderx_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index 4af9744cc6d0..0eb5eb97fd74 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
 DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
 DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
 
-struct debugfs_entry *lmc_dfs_ents[] = {
+static struct debugfs_entry *lmc_dfs_ents[] = {
 	&debugfs_mask0,
 	&debugfs_mask2,
 	&debugfs_parity_test,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
  2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
@ 2020-07-27 13:56 ` Robert Richter
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Richter @ 2020-07-27 13:56 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Hulk Robot, Borislav Petkov, Mauro Carvalho Chehab, Tony Luck,
	linux-edac

On 14.07.20 22:23:08, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/edac/thunderx_edac.c:457:22: warning:
>  symbol 'lmc_dfs_ents' was not declared. Should it be static?
> 
> Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
> marks it static.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Robert Richter <rrichter@marvell.com>

> ---
>  drivers/edac/thunderx_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 4af9744cc6d0..0eb5eb97fd74 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
>  DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
>  DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
>  
> -struct debugfs_entry *lmc_dfs_ents[] = {
> +static struct debugfs_entry *lmc_dfs_ents[] = {
>  	&debugfs_mask0,
>  	&debugfs_mask2,
>  	&debugfs_parity_test,
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
2020-07-27 13:56 ` Robert Richter

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git