From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Feng zhou <zhoufeng.zf@bytedance.com>
Cc: bp@alien8.de, mchehab@kernel.org, tony.luck@intel.com,
james.morse@arm.com, rrichter@marvell.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
liuxian.1@bytedance.com
Subject: Re: [PATCH] x86/MCE/AMD, EDAC/mce_amd
Date: Mon, 10 Aug 2020 14:10:31 -0500 [thread overview]
Message-ID: <20200810190958.GA3406209@yaz-nikka.amd.com> (raw)
In-Reply-To: <20200809043559.9740-1-zhoufeng.zf@bytedance.com>
On Sun, Aug 09, 2020 at 12:35:59PM +0800, Feng zhou wrote:
> From: zhoufeng <zhoufeng.zf@bytedance.com>
>
> The edac_mce_amd module calls decode_dram_ecc() on AMD Family17h and
> later systems. This function is used in amd64_edac_mod to do
> system-specific decoding for DRAM ECC errors. The function takes a
> "NodeId" as a parameter.
>
> In AMD documentation, NodeId is used to identify a physical die in a
> system. This can be used to identify a node in the AMD_NB code and also
> it is used with umc_normaddr_to_sysaddr().
>
> However, the input used for decode_dram_ecc() is currently the NUMA node
> of a logical CPU. so this will cause the address translation function to
> fail or report incorrect results.
>
> Signed-off-by: zhoufeng <zhoufeng.zf@bytedance.com>
> ---
> drivers/edac/mce_amd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> index 325aedf46ff2..73c805113322 100644
> --- a/drivers/edac/mce_amd.c
> +++ b/drivers/edac/mce_amd.c
> @@ -996,7 +996,7 @@ static void decode_smca_error(struct mce *m)
> }
>
> if (bank_type == SMCA_UMC && xec == 0 && decode_dram_ecc)
> - decode_dram_ecc(cpu_to_node(m->extcpu), m);
> + decode_dram_ecc(topology_physical_package_id(m->extcpu), m);
This will break on Naples systems, because the NodeId and the physical
package ID will not match.
I can send a patch soon that will work for Naples, Rome, and later
systems.
Thanks,
Yazen
next prev parent reply other threads:[~2020-08-10 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 4:35 [PATCH] x86/MCE/AMD, EDAC/mce_amd Feng zhou
2020-08-10 19:10 ` Yazen Ghannam [this message]
2020-08-12 4:08 ` [External] " zhoufeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810190958.GA3406209@yaz-nikka.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxian.1@bytedance.com \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=zhoufeng.zf@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).