From: Borislav Petkov <bp@alien8.de>
To: Talel Shenhar <talel@amazon.com>
Cc: mchehab@kernel.org, james.morse@arm.com, davem@davemloft.net,
gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will@kernel.org,
linux-edac@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, hhhawa@amazon.com,
ronenk@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
eitan@amazon.com
Subject: Re: [PATCH v9 2/2] EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller EDAC
Date: Sat, 15 Aug 2020 20:33:58 +0200 [thread overview]
Message-ID: <20200815183358.GE25814@zn.tnic> (raw)
In-Reply-To: <20200728095155.18506-3-talel@amazon.com>
On Tue, Jul 28, 2020 at 12:51:55PM +0300, Talel Shenhar wrote:
> +static void al_mc_edac_check(struct mem_ctl_info *mci)
> +{
> + struct al_mc_edac *al_mc = mci->pvt_info;
> +
> + if (al_mc->irq_ue <= 0)
> + handle_ue(mci);
> +
> + if (al_mc->irq_ce <= 0)
> + handle_ce(mci);
> +}
> +
> +static irqreturn_t al_mc_edac_irq_handler_ue(int irq, void *info)
> +{
> + struct platform_device *pdev = info;
> + struct mem_ctl_info *mci = platform_get_drvdata(pdev);
> +
> + if (handle_ue(mci))
> + return IRQ_HANDLED;
> + return IRQ_NONE;
> +}
> +
> +static irqreturn_t al_mc_edac_irq_handler_ce(int irq, void *info)
> +{
> + struct platform_device *pdev = info;
> + struct mem_ctl_info *mci = platform_get_drvdata(pdev);
> +
> + if (handle_ce(mci))
> + return IRQ_HANDLED;
> + return IRQ_NONE;
> +}
> +
> +static enum scrub_type al_mc_edac_get_scrub_mode(void __iomem *mmio_base)
> +{
> + u32 ecccfg0;
> +
> + ecccfg0 = readl(mmio_base + AL_MC_ECC_CFG);
> +
> + if (FIELD_GET(AL_MC_ECC_CFG_SCRUB_DISABLED, ecccfg0))
> + return SCRUB_NONE;
> + else
> + return SCRUB_HW_SRC;
> +}
> +
> +static void devm_al_mc_edac_free(void *data)
> +{
> + edac_mc_free(data);
> +}
> +
> +static void devm_al_mc_edac_del(void *data)
> +{
> + edac_mc_del_mc(data);
> +}
From a previous review:
I said:
> Drop the "al_mc_edac_" prefix from most of the static functions. You can
> leave it in the probe function or the IRQ handler so that it is visible
> in stack traces but all those small functions don't need that prefix.
You replied with:
> Shall be part of v7.
and yet it ain't part of any v<num>.
Why?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-08-15 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:51 [PATCH v9 0/2] Amazon's Annapurna Labs Memory Controller EDAC Talel Shenhar
2020-07-28 9:51 ` [PATCH v9 1/2] dt-bindings: edac: al-mc-edac: " Talel Shenhar
2020-07-28 9:51 ` [PATCH v9 2/2] EDAC: al-mc-edac: Introduce " Talel Shenhar
2020-08-15 18:33 ` Borislav Petkov [this message]
2020-08-16 9:17 ` Shenhar, Talel
2020-08-16 11:22 ` Borislav Petkov
2020-08-16 11:35 ` Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815183358.GE25814@zn.tnic \
--to=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eitan@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).