From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41858C433E1 for ; Mon, 17 Aug 2020 10:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2B66206FA for ; Mon, 17 Aug 2020 10:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="pGAVTOhB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbgHQKaa (ORCPT ); Mon, 17 Aug 2020 06:30:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgHQKa3 (ORCPT ); Mon, 17 Aug 2020 06:30:29 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1888C061389; Mon, 17 Aug 2020 03:30:29 -0700 (PDT) Received: from zn.tnic (p200300ec2f26be0071e1cf3fa1f5ba15.dip0.t-ipconnect.de [IPv6:2003:ec:2f26:be00:71e1:cf3f:a1f5:ba15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 53FBC1EC02C3; Mon, 17 Aug 2020 12:30:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1597660225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=0uSq9qk/RW8bveLRIOi0gn3aCCuOfz0gR3ySVhVswAI=; b=pGAVTOhBS76mB5TZG2zXGksNaiYoOycCZ+tjVARYWosgItgDF9WcPI8PQSEnQTOxhXnwL9 H5lr8ShVXvmRyDz6urOoJcGC4BSN6hdvaggbOxLdTDoZ64Ph5dauUntDo+IRixwDOMd0C+ A9loz87jTm8P7dy54ny19aYqi0SWlnU= Date: Mon, 17 Aug 2020 12:31:21 +0200 From: Borislav Petkov To: Qinglang Miao Cc: Greg Kroah-Hartman , Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] RAS/CEC: Convert to DEFINE_SHOW_ATTRIBUTE Message-ID: <20200817103121.GF549@zn.tnic> References: <20200716085834.11484-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200716085834.11484-1-miaoqinglang@huawei.com> Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Jul 16, 2020 at 04:58:34PM +0800, Qinglang Miao wrote: > From: Yongqiang Liu > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yongqiang Liu > --- > drivers/ras/cec.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c > index a992bb426..ed47b59e4 100644 > --- a/drivers/ras/cec.c > +++ b/drivers/ras/cec.c > @@ -435,7 +435,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(action_threshold_ops, u64_get, action_threshold_set, "% > > static const char * const bins[] = { "00", "01", "10", "11" }; > > -static int array_dump(struct seq_file *m, void *v) > +static int array_show(struct seq_file *m, void *v) > { > struct ce_array *ca = &ce_arr; > int i; > @@ -467,18 +467,7 @@ static int array_dump(struct seq_file *m, void *v) > return 0; > } > > -static int array_open(struct inode *inode, struct file *filp) > -{ > - return single_open(filp, array_dump, NULL); > -} > - > -static const struct file_operations array_ops = { > - .owner = THIS_MODULE, > - .open = array_open, > - .read_iter = seq_read_iter, $ test-apply.sh /tmp/01-ras-cec-convert_to_define_show_attribute.patch checking file drivers/ras/cec.c Hunk #2 FAILED at 467. 1 out of 3 hunks FAILED Apply? (y/n) n Where did this .read_iter come from? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette