Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Gabriele Paoloni <gabriele.paoloni@intel.com>,
	Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
	Aristeu Rozanski <aris@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC, i7core, sb, pnd2, skx: Fix error event severity
Date: Tue, 18 Aug 2020 15:45:22 +0200
Message-ID: <20200818134522.GD31641@zn.tnic> (raw)
In-Reply-To: <20200707194324.14884-1-tony.luck@intel.com>

On Tue, Jul 07, 2020 at 12:43:24PM -0700, Tony Luck wrote:
> IA32_MCG_STATUS.RIPV indicates whether the return RIP value pushed onto
> the stack as part of machine check delivery is valid or not.
> 
> Various drivers copied a code fragment that uses the RIPV bit to
> determine the severity of the error as either HW_EVENT_ERR_UNCORRECTED
> or HW_EVENT_ERR_FATAL, but this check is reversed (marking errors where
> RIPV is set as "FATAL").
> 
> Reverse the tests so that the error is marked fatal when RIPV is not set.
> 
> Reported-by: Gabriele Paoloni <gabriele.paoloni@intel.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/edac/i7core_edac.c | 4 ++--
>  drivers/edac/pnd2_edac.c   | 2 +-
>  drivers/edac/sb_edac.c     | 4 ++--
>  drivers/edac/skx_common.c  | 4 ++--
>  4 files changed, 7 insertions(+), 7 deletions(-)

Queued on edac-urgent, will send to Linus next week.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:43 Tony Luck
2020-08-18 13:45 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818134522.GD31641@zn.tnic \
    --to=bp@alien8.de \
    --cc=aris@redhat.com \
    --cc=gabriele.paoloni@intel.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git