From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20134C433DF for ; Thu, 27 Aug 2020 07:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F083B20786 for ; Thu, 27 Aug 2020 07:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598512080; bh=Fn0rZm+UtPquTJVp8C3STQQnW6xRFaI+UQd529qNQHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pYHBIVpz82ywoSUzMSzTY4ifXBHjYyFRXPgtS9ksUxva8G6uRw8H0bQD/XFGqyUuE 8TgeX7nUdcGoWvbKOJkWV5+Sg3ojLpIlHZqsVqkicEUb8cXp+YXkGu5SWz05ub2dQh hvY5gp+c8A4B84FM9xr7aSGIrVY85zWSQOQFL4iQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbgH0HH7 (ORCPT ); Thu, 27 Aug 2020 03:07:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbgH0HHz (ORCPT ); Thu, 27 Aug 2020 03:07:55 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC1F522BF3; Thu, 27 Aug 2020 07:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598512075; bh=Fn0rZm+UtPquTJVp8C3STQQnW6xRFaI+UQd529qNQHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ky0xDoZnV/jmiNfyFyChdT7vic/gauQEEwtiEYul7mLAQudlJfM+0jIbLXxpvd2Az oSApf3UxVOg6tJTW7MhA9TXFAtc2qlTSpXslGs40e3yr9biRBrAQLBa+v4NTfueJMR nWIjPh73I4zUJ30pIHgJZ21nvNoz3Hq1k/UYT/jI= From: Krzysztof Kozlowski To: Stefan Schaeckeler , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Joel Stanley , Andrew Jeffery , Tero Kristo , linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] EDAC/ti: Fix handling of platform_get_irq() error Date: Thu, 27 Aug 2020 09:07:43 +0200 Message-Id: <20200827070743.26628-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200827070743.26628-1-krzk@kernel.org> References: <20200827070743.26628-1-krzk@kernel.org> Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC") Signed-off-by: Krzysztof Kozlowski --- drivers/edac/ti_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index 6e52796a0b41..e7eae20f83d1 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev) /* add EMIF ECC error handler */ error_irq = platform_get_irq(pdev, 0); - if (!error_irq) { + if (error_irq < 0) { + ret = error_irq; edac_printk(KERN_ERR, EDAC_MOD_NAME, "EMIF irq number not defined.\n"); goto err; -- 2.17.1