From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53B1C433DF for ; Thu, 27 Aug 2020 10:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74C0522BF5 for ; Thu, 27 Aug 2020 10:40:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="L//sqCAw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgH0KkK (ORCPT ); Thu, 27 Aug 2020 06:40:10 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47972 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728555AbgH0KkK (ORCPT ); Thu, 27 Aug 2020 06:40:10 -0400 Received: from zn.tnic (p200300ec2f104500a980b16b3f9103d9.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:4500:a980:b16b:3f91:3d9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 400221EC037C; Thu, 27 Aug 2020 12:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1598524804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=8mEIx/a3yrzoKPFt6Yw2usL4Qm923jMWVkTk06lBsNQ=; b=L//sqCAwjZGwmVXuFDW8sL4eoTT4XyJZgIGi5kN0gd9QXF1ygzZ0qlS5ou+49LLJbAVwD+ wSC9yFS7ImOYWMXM7BQ1ljuYJwbN4qBZf6TFkzI5EBeEUo1hLvBRVxldj6poARf1eDIfrI QBEgMqCnez+tMgf4g1JTbGkCx5nVkNw= Date: Thu, 27 Aug 2020 12:40:00 +0200 From: Borislav Petkov To: Alison Wang Cc: James Morse , "tony.luck@intel.com" , "mchehab@kernel.org" , "rrichter@marvell.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores Message-ID: <20200827104000.GB30897@zn.tnic> References: <20200709082215.12829-1-alison.wang@nxp.com> <92811e33-2f57-244b-4b50-c2831b09b835@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Aug 26, 2020 at 03:03:15AM +0000, Alison Wang wrote: > [Alison] I have a look at this patch. This patch doesn't complete all > the functions in my patch. Yep, but pls work together to see if a single driver can support your hw too. > It is just to report errors, but error injection function is all > removed. Right, because you can't use that on this hw, apparently. Also note that you should disable error injection in production for obvious reasons. Thus all the error injection stuff in EDAC is behind CONFIG_EDAC_DEBUG which should be off in production kernels. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette