From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1342C433E7 for ; Tue, 1 Sep 2020 10:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9562206EB for ; Tue, 1 Sep 2020 10:13:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="WKMbQ7cO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726078AbgIAKNy (ORCPT ); Tue, 1 Sep 2020 06:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbgIAKNx (ORCPT ); Tue, 1 Sep 2020 06:13:53 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4144EC061244; Tue, 1 Sep 2020 03:13:53 -0700 (PDT) Received: from zn.tnic (p200300ec2f111c000c6e903c2b8b7428.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:1c00:c6e:903c:2b8b:7428]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C4D711EC0246; Tue, 1 Sep 2020 12:13:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1598955230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=NY4YDSEDfN5GOV9jqboSUJfKtJ2U0iuZgeu2bas8HPA=; b=WKMbQ7cOUg0o41V7Svb+yFavjB/WLzXiMmdevAkS6ZVd3vPEPCMvMPXTgTn9NlQp4hKqpr n2Yblg31FxkJ4cky3yLidaq1+YZyxoADfCQfoO48tgVBL+TVC2awZALlNBB9TCCudug6vX E6/1AAGrwk3S3TuStT+BxopN57N43gg= Date: Tue, 1 Sep 2020 12:13:45 +0200 From: Borislav Petkov To: Dinghao Liu Cc: kjlu@umn.edu, Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Niklas =?utf-8?Q?S=C3=B6derlund?= , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: i5100_edac: Fix error handling code in i5100_init_one Message-ID: <20200901101345.GA8392@zn.tnic> References: <20200826121437.31606-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200826121437.31606-1-dinghao.liu@zju.edu.cn> Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Aug 26, 2020 at 08:14:37PM +0800, Dinghao Liu wrote: > When pci_get_device_func() fails, we don't need to execute > pci_dev_put(). But mci should be freed to prevent memleak. > When pci_enable_device() fails, we don't need to disable > einj either. > > Fixes: 52608ba205461 ("i5100_edac: probe for device 19 function 0") > Signed-off-by: Dinghao Liu > --- > drivers/edac/i5100_edac.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette