From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44685C433E6 for ; Tue, 1 Sep 2020 18:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2411C20767 for ; Tue, 1 Sep 2020 18:51:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="RAsJU/OB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728925AbgIASvo (ORCPT ); Tue, 1 Sep 2020 14:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728885AbgIASvo (ORCPT ); Tue, 1 Sep 2020 14:51:44 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF011C061244; Tue, 1 Sep 2020 11:51:43 -0700 (PDT) Received: from zn.tnic (p200300ec2f111c0024978c1e0fa9a8a0.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:1c00:2497:8c1e:fa9:a8a0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 21A361EC0402; Tue, 1 Sep 2020 20:51:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1598986300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=tc9v2kAw0PVA7I9RWib1GcZ989FrHTMdQDbO4s8BKM8=; b=RAsJU/OBy9MVu0v9nJvhrlC7qFhgUbojEJXggI3sDNKRqkznwo4p4O5LUZrWOgi1S4LGXA WHdxRWK8gce4sytF0KJtgIJSRBm2gxHNLMp93EprPEVSnf+KGt8I3HKKMBZaeorURfc/QT pUus+ahMEd2CnViPPQyRsecadxqUEEE= Date: Tue, 1 Sep 2020 20:51:36 +0200 From: Borislav Petkov To: Krzysztof Kozlowski Cc: Stefan Schaeckeler , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Joel Stanley , Andrew Jeffery , Tero Kristo , linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] EDAC/aspeed: Fix handling of platform_get_irq() error Message-ID: <20200901185136.GD8392@zn.tnic> References: <20200827070743.26628-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200827070743.26628-1-krzk@kernel.org> Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Aug 27, 2020 at 09:07:42AM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/edac/aspeed_edac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Both applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette