From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CABC43461 for ; Wed, 9 Sep 2020 18:07:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B3D321D90 for ; Wed, 9 Sep 2020 18:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="KC+fv42A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725772AbgIISHA (ORCPT ); Wed, 9 Sep 2020 14:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730175AbgIISGz (ORCPT ); Wed, 9 Sep 2020 14:06:55 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12ECCC061573; Wed, 9 Sep 2020 11:06:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f0ae70079c27cf3fd7a9e22.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e700:79c2:7cf3:fd7a:9e22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EF9361EC0284; Wed, 9 Sep 2020 20:06:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1599674813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=oowZjMW+t+gS+Tj+kswLoes6LCsEuL0zY6OVKKw0VoY=; b=KC+fv42AE8KvHoZnZa1hmGfSvMMrKganG1by/zmfcpNx7yreZnAXpynKstowe2jagWQpCG 38bSFrGCcM7Rh9z26yvCkm9KWWzli9cDM+Y0d8jkDK2ZvUIxardRaaKT6kTn8drxq3yETp F8O01vLkf9ESzh3yU5X2hCErv0pHZNY= Date: Wed, 9 Sep 2020 20:06:47 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH v2 1/8] x86/CPU/AMD: Save NodeId on AMD-based systems Message-ID: <20200909180647.GF12237@zn.tnic> References: <20200903200144.310991-1-Yazen.Ghannam@amd.com> <20200903200144.310991-2-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200903200144.310991-2-Yazen.Ghannam@amd.com> Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Sep 03, 2020 at 08:01:37PM +0000, Yazen Ghannam wrote: > From: Yazen Ghannam > > AMD systems provide a "NodeId" value that represents a global ID > indicating to which "Node" a logical CPU belongs. The "Node" is a > physical structure equivalent to a Die, and it should not be confused > with logical structures like NUMA node. So we said in Documentation/x86/topology.rst that: "The kernel does not care about the concept of physical sockets because a socket has no relevance to software. It's an electromechanical component." Now, you're talking, AFAIU, about physical components. Why do you need them? What is then: - cpuinfo_x86.phys_proc_id: The physical ID of the package. This information is retrieved via CPUID and deduced from the APIC IDs of the cores in the package. supposed to mean? Why isn't phys_proc_id != node_id? And so on and so on. Please get the nomenclature straight first and then we can talk changes. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette