From: Borislav Petkov <bp@alien8.de>
To: Alex Kluver <alex.kluver@hpe.com>
Cc: linux-edac@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, ardb@kernel.org,
mchehab@kernel.org, russ.anderson@hpe.com,
dimitri.sivanich@hpe.com, kluveralex@gmail.com
Subject: Re: [PATCH v2 2/2] cper,edac,efi: Memory Error Record: bank group/address and chip id
Date: Tue, 15 Sep 2020 18:36:13 +0200 [thread overview]
Message-ID: <20200915163613.GP14436@zn.tnic> (raw)
In-Reply-To: <20200819143544.155096-3-alex.kluver@hpe.com>
On Wed, Aug 19, 2020 at 09:35:44AM -0500, Alex Kluver wrote:
> Updates to the UEFI 2.8 Memory Error Record allow splitting the bank field
> into bank address and bank group, and using the last 3 bits of the extended
> field as a chip identifier.
>
> When needed, print correct version of bank field, bank group, and chip
> identification
>
> Based on UEFI 2.8 Table 299. Memory Error Record
Whoever commits this - those last two sentences need fullstops.
> Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
> Reviewed-by: Kyle Meyer <kyle.meyer@hpe.com>
> Reviewed-by: Russ Anderson <russ.anderson@hpe.com>
> Signed-off-by: Alex Kluver <alex.kluver@hpe.com>
> ---
>
> v1 -> v2:
> * Add static inline cper_get_mem_extension() to make it
> more readable, as suggested by Borislav Petkov.
>
> * Add second patch for bank field, bank group, and chip id.
>
> ---
> drivers/edac/ghes_edac.c | 9 +++++++++
> drivers/firmware/efi/cper.c | 9 +++++++++
> include/linux/cper.h | 8 ++++++++
> 3 files changed, 26 insertions(+)
For the EDAC bits:
Acked-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-15 22:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 14:35 [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates Alex Kluver
2020-08-19 14:35 ` [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record Alex Kluver
2020-09-15 16:33 ` Borislav Petkov
2020-09-15 17:07 ` Ard Biesheuvel
2020-09-15 17:12 ` Ard Biesheuvel
2020-09-15 17:19 ` Borislav Petkov
2020-09-16 13:09 ` Ard Biesheuvel
2020-09-16 18:10 ` Borislav Petkov
2020-09-16 18:12 ` Russ Anderson
2020-08-19 14:35 ` [PATCH v2 2/2] cper,edac,efi: Memory Error Record: bank group/address and chip id Alex Kluver
2020-09-15 16:36 ` Borislav Petkov [this message]
2020-09-14 16:44 ` [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates Russ Anderson
2020-09-15 15:07 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915163613.GP14436@zn.tnic \
--to=bp@alien8.de \
--cc=alex.kluver@hpe.com \
--cc=ardb@kernel.org \
--cc=dimitri.sivanich@hpe.com \
--cc=kluveralex@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=russ.anderson@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).