From: Borislav Petkov <bp@alien8.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Robert Richter <rrichter@marvell.com>,
York Sun <york.sun@nxp.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57
Date: Tue, 13 Oct 2020 13:31:47 +0200 [thread overview]
Message-ID: <20201013113147.GD28215@zn.tnic> (raw)
In-Reply-To: <20201013111346.GG11648@pengutronix.de>
On Tue, Oct 13, 2020 at 01:13:46PM +0200, Sascha Hauer wrote:
> Have you run checkpatch on a tree with this patch applied? If not, then
> yes, it's undocumented as the docs are added with this patch.
Aha, I'm usually running checkpatch on the patch itself so if this patch
adds it then checkpatch is doing it wrong. Oh well.
> I never heard of such a requirement. How is the length defined? Is it
> only the length of the variable name or is it the length of the name
> including the type? Including the array braces [] or not?
The total textual length.
> What if a variable shall be initialized with the value of an earlier
> declared variable, do I have to make up variable names with a suitable
> length in that case?
In that case you should order it so that the initialization is correct.
> What if shorter_var_name and even_shorter are of same type, can I
> still write them in a single line?
You simply sort them so that it remains a reversed xmas tree.
> Finally, Is this documented somewhere?
No, would it make any difference if it were?
> I hope that was a joke from you that I didn't understand.
This is the convention that is used in the tip tree and I'm using it in
the EDAC tree too. Just think of it as a subsystem formatting rule.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-10-13 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:57 [PATCH 0/2] Add L1 and L2 error detection for A53 and A57 Sascha Hauer
2020-08-13 7:57 ` [PATCH 1/2] drivers/edac: " Sascha Hauer
2020-08-26 8:41 ` Borislav Petkov
2020-10-13 11:13 ` Sascha Hauer
2020-10-13 11:31 ` Borislav Petkov [this message]
2020-08-13 7:57 ` [PATCH 2/2] arm64: dts: ls104x: Add L1/L2 cache edac node Sascha Hauer
2021-02-01 11:57 [PATCH iv4 0/2] Add L1 and L2 error detection for A53 and A57 Sascha Hauer
2021-02-01 11:57 ` [PATCH 1/2] drivers/edac: " Sascha Hauer
2021-04-01 11:06 [PATCH v5 0/2] " Sascha Hauer
2021-04-01 11:06 ` [PATCH 1/2] drivers/edac: " Sascha Hauer
2021-04-02 10:06 ` Marc Zyngier
2021-04-15 10:15 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013113147.GD28215@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=s.hauer@pengutronix.de \
--cc=tony.luck@intel.com \
--cc=york.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).