From: Zhang Qilong <zhangqilong3@huawei.com>
To: <bp@alien8.de>, <james.morse@arm.com>, <rric@kernel.org>
Cc: <mchehab@kernel.org>, <tony.luck@intel.com>,
<linux-edac@vger.kernel.org>
Subject: [PATCH -next] EDAC/amd64: Discard unnecessary break
Date: Mon, 26 Oct 2020 17:11:03 +0800 [thread overview]
Message-ID: <20201026091103.67780-1-zhangqilong3@huawei.com> (raw)
A 'break' is unnecessary because of previous 'return'.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/edac/amd64_edac.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 1362274d840b..a1c9e68b35d9 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2461,14 +2461,11 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
case 0x20:
case 0x21:
return 0;
- break;
case 0x22:
case 0x23:
return 1;
- break;
default:
return err_sym >> 4;
- break;
}
/* x8 symbols */
else
@@ -2478,17 +2475,13 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
WARN(1, KERN_ERR "Invalid error symbol: 0x%x\n",
err_sym);
return -1;
- break;
case 0x11:
return 0;
- break;
case 0x12:
return 1;
- break;
default:
return err_sym >> 3;
- break;
}
return -1;
}
--
2.17.1
next reply other threads:[~2020-10-26 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 9:11 Zhang Qilong [this message]
2020-10-26 11:12 ` [PATCH -next] EDAC/amd64: Discard unnecessary break Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026091103.67780-1-zhangqilong3@huawei.com \
--to=zhangqilong3@huawei.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).