linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>, linux-edac <linux-edac@vger.kernel.org>
Subject: Re: EDAC instances probing
Date: Fri, 22 Jan 2021 22:45:02 -0600	[thread overview]
Message-ID: <20210123044502.GA869026@yaz-nikka.amd.com> (raw)
In-Reply-To: <20210113203316.GI16960@zn.tnic>

On Wed, Jan 13, 2021 at 09:33:16PM +0100, Borislav Petkov wrote:
> I'm soo stupid. Usually I do the simplest solution but this time it has
> escaped me.
> 
> But I caught it now:
> 
> ---
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 9868f95a5622..105d00b27be2 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3528,8 +3528,7 @@ static bool ecc_enabled(struct amd64_pvt *pvt)
>  				     MSR_IA32_MCG_CTL, nid);
>  	}
>  
> -	amd64_info("Node %d: DRAM ECC %s.\n",
> -		   nid, (ecc_en ? "enabled" : "disabled"));
> +	edac_dbg(3, "Node %d: DRAM ECC %s.\n", nid, (ecc_en ? "enabled" : "disabled"));
>  
>  	if (!ecc_en || !nb_mce_en)
>  		return false;
> @@ -3689,11 +3688,6 @@ static struct amd64_family_type *per_family_init(struct amd64_pvt *pvt)
>  		return NULL;
>  	}
>  
> -	amd64_info("%s %sdetected (node %d).\n", fam_type->ctl_name,
> -		     (pvt->fam == 0xf ?
> -				(pvt->ext_model >= K8_REV_F  ? "revF or later "
> -							     : "revE or earlier ")
> -				 : ""), pvt->mc_node_id);
>  	return fam_type;
>  }
>  
> @@ -3867,6 +3861,12 @@ static int probe_one_instance(unsigned int nid)
>  
>  	dump_misc_regs(pvt);
>  
> +	amd64_info("%s %sdetected (node %d).\n", fam_type->ctl_name,
> +		     (pvt->fam == 0xf ?
> +				(pvt->ext_model >= K8_REV_F  ? "revF or later "
> +							     : "revE or earlier ")
> +				 : ""), pvt->mc_node_id);
> +
>  	return ret;
>  
>  err_enable:
> 
> --

I like it. I tested it out on one of my server systems, and it seems to
work well.

Tested-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

      reply	other threads:[~2021-01-23  4:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 18:19 EDAC instances probing Borislav Petkov
2020-12-11 20:35 ` Yazen Ghannam
2020-12-11 20:58   ` Borislav Petkov
2021-01-13 20:33     ` Borislav Petkov
2021-01-23  4:45       ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210123044502.GA869026@yaz-nikka.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).