From: Yazen Ghannam <firstname.lastname@example.org> To: Borislav Petkov <email@example.com> Cc: "Luck, Tony" <firstname.lastname@example.org>, Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Mauro Carvalho Chehab <email@example.com>, James Morse <firstname.lastname@example.org>, Robert Richter <email@example.com> Subject: Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Date: Tue, 15 Jun 2021 12:32:21 -0400 [thread overview] Message-ID: <20210615163221.GA2991@aus-x-yghannam.amd.com> (raw) In-Reply-To: <YMjRGFiqp2HNWUrZ@zn.tnic> On Tue, Jun 15, 2021 at 06:11:04PM +0200, Borislav Petkov wrote: > On Tue, Jun 15, 2021 at 12:00:09PM -0400, Yazen Ghannam wrote: > > So I think we can downgrade this warning to a debug message, if the > > module stays builtin. And/or we change the default config option to > > module, and we make sure the module only autoloads in the proper cases. > > > > What do you think? > > I think, as I said before, that we should simply not load this in > guests. Then this will be taken care of once and for all and we can do > whatever we want on baremetal, as to what error message to issue and how > many times to issue it, whether the decoder is builtin or default y or > yadda yadda. > > Because even if you say in a guest: > > pr_warn_once("Decoding supported only on Scalable MCA processors.\n"); > > you're kinda misleading because the guest might be an SMCA processor but > not all features are emulated, including SMCA. So it is not really an > SMCA processor but some not really existant hybrid or so. > > So since this whole SMCA thing does not apply to virtualization, we > should simply not load on virt and be done with it. > Yes, I agree. I was a bit confused about the X86_FEATURE_HYPERVISOR thing, but I think I get it. This definitely looks simple to do. Thanks, Yazen
next prev parent reply other threads:[~2021-06-15 16:32 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 21:21 Smita Koralahalli 2021-06-14 22:01 ` Borislav Petkov 2021-06-14 22:25 ` Luck, Tony 2021-06-15 9:16 ` Borislav Petkov 2021-06-15 15:08 ` Yazen Ghannam 2021-06-15 15:18 ` Borislav Petkov 2021-06-15 16:00 ` Yazen Ghannam 2021-06-15 16:11 ` Borislav Petkov 2021-06-15 16:32 ` Yazen Ghannam [this message] 2021-06-15 16:45 ` [PATCH] EDAC/Intel: Do not load EDAC driver when running as a guest Luck, Tony 2021-06-15 17:00 ` Borislav Petkov 2021-06-15 17:44 ` [PATCH v2] " Luck, Tony 2021-06-15 17:25 ` [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210615163221.GA2991@aus-x-yghannam.amd.com \ --firstname.lastname@example.org \ --cc=Smita.KoralahalliChannabasappa@amd.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).