From: kernel test robot <lkp@intel.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
yazen.ghannam@amd.com, bp@alien8.de, mchehab@kernel.org,
tony.luck@intel.com, james.morse@arm.com, rric@kernel.org
Cc: kbuild-all@lists.01.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] drivers:edac: Use DEVICE_ATTR helper macros
Date: Sun, 11 Jul 2021 19:48:49 +0800 [thread overview]
Message-ID: <202107111911.4Zb3i0zK-lkp@intel.com> (raw)
In-Reply-To: <20210711072711.86180-1-dwaipayanray1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3999 bytes --]
Hi Dwaipayan,
I love your patch! Yet something to improve:
[auto build test ERROR on ras/edac-for-next]
[also build test ERROR on v5.13 next-20210709]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dwaipayan-Ray/drivers-edac-Use-DEVICE_ATTR-helper-macros/20210711-152925
base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/adad6ecbf0efe710fee1495b85d840ad53825124
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dwaipayan-Ray/drivers-edac-Use-DEVICE_ATTR-helper-macros/20210711-152925
git checkout adad6ecbf0efe710fee1495b85d840ad53825124
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/edac/amd64_edac.c: In function 'dbam_show':
>> drivers/edac/amd64_edac.c:570:20: error: 'struct amd64_pvt' has no member named 'dbam'; did you mean 'dbam0'?
570 | EDAC_DCT_ATTR_SHOW(dbam);
| ^~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c: In function 'topmem_show':
>> drivers/edac/amd64_edac.c:571:20: error: 'struct amd64_pvt' has no member named 'topmem'; did you mean 'top_mem'?
571 | EDAC_DCT_ATTR_SHOW(topmem);
| ^~~~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c: In function 'topmem2_show':
>> drivers/edac/amd64_edac.c:572:20: error: 'struct amd64_pvt' has no member named 'topmem2'; did you mean 'top_mem2'?
572 | EDAC_DCT_ATTR_SHOW(topmem2);
| ^~~~~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:572:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
572 | EDAC_DCT_ATTR_SHOW(topmem2);
| ^~~~~~~~~~~~~~~~~~
drivers/edac/amd64_edac.c: In function 'topmem_show':
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:571:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
571 | EDAC_DCT_ATTR_SHOW(topmem);
| ^~~~~~~~~~~~~~~~~~
drivers/edac/amd64_edac.c: In function 'dbam_show':
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:570:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
570 | EDAC_DCT_ATTR_SHOW(dbam);
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +570 drivers/edac/amd64_edac.c
568
569 EDAC_DCT_ATTR_SHOW(dhar);
> 570 EDAC_DCT_ATTR_SHOW(dbam);
> 571 EDAC_DCT_ATTR_SHOW(topmem);
> 572 EDAC_DCT_ATTR_SHOW(topmem2);
573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65260 bytes --]
prev parent reply other threads:[~2021-07-11 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 7:27 [PATCH] drivers:edac: Use DEVICE_ATTR helper macros Dwaipayan Ray
2021-07-11 11:48 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107111911.4Zb3i0zK-lkp@intel.com \
--to=lkp@intel.com \
--cc=bp@alien8.de \
--cc=dwaipayanray1@gmail.com \
--cc=james.morse@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).