From: Yazen Ghannam <yazen.ghannam@amd.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
"bp@alien8.de" <bp@alien8.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"rric@kernel.org" <rric@kernel.org>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros
Date: Tue, 13 Jul 2021 12:01:41 -0400 [thread overview]
Message-ID: <20210713160141.GA9752@aus-x-yghannam.amd.com> (raw)
In-Reply-To: <43f0eb92643a4613992714effefed757@intel.com>
On Tue, Jul 13, 2021 at 03:27:01PM +0000, Luck, Tony wrote:
> > Instead of "open coding" DEVICE_ATTR, use the corresponding
> > helper macros DEVICE_ATTR_{RW,RO,WO} in amd64_edac.c
> >
> > Some function names needed to be changed to match the device
> > conventions <foo>_show and <foo>_store, but the functionality
> > itself is unchanged.
> >
> > The devices using EDAC_DCT_ATTR_SHOW() are left unchanged.
> >
> > Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
>
> Yazen,
>
> Boris is on vacation. Should I queue this change?
>
Hi Tony,
Yes, please.
Thanks,
Yazen
prev parent reply other threads:[~2021-07-13 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 6:51 [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros Dwaipayan Ray
2021-07-13 15:27 ` Luck, Tony
2021-07-13 16:01 ` Yazen Ghannam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713160141.GA9752@aus-x-yghannam.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=dwaipayanray1@gmail.com \
--cc=james.morse@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).