From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7534BC433F5 for ; Mon, 6 Sep 2021 01:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D23661076 for ; Mon, 6 Sep 2021 01:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239565AbhIFB0C (ORCPT ); Sun, 5 Sep 2021 21:26:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:37826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239573AbhIFBYX (ORCPT ); Sun, 5 Sep 2021 21:24:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52E2061076; Mon, 6 Sep 2021 01:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630891326; bh=ohGDI1JxsPbCYZG/zalE3wIOE61oV2iX/8ohfb05En4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YoSeSw49SlSVci9AlBFuJgkWxUs3uRmsjMk3jGKhW5jXPjG4BwY9Xvq6slUXj7MZA OGqO20HaZAVBONtT8c/JMfQbSLIjDtcUR1SnFBpiLAIUvaEuClRS7m2X1LHpnURmgy rrUtDJvM1R5raksnAdnpw5/d8YCvZZy1vPy6ceqIkEE0C24pZN8GVEmW3xor8fMk1k iKkmwFLKKhZmpL72s4lz1vSmkSRXZPhgN1/XuDrz/LrwWKkj7om2WzBgk0DfU8RbJo m8O+0iyFmggV8apzU81b9X+JFxek6Rw4Bezd8w6/MmJgts9eAA1jShWgNmpuewfkkT fbdBMgbaALniw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Smita Koralahalli , Borislav Petkov , Yazen Ghannam , Kim Phillips , Sasha Levin , linux-edac@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 10/39] EDAC/mce_amd: Do not load edac_mce_amd module on guests Date: Sun, 5 Sep 2021 21:21:24 -0400 Message-Id: <20210906012153.929962-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210906012153.929962-1-sashal@kernel.org> References: <20210906012153.929962-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org From: Smita Koralahalli [ Upstream commit 767f4b620edadac579c9b8b6660761d4285fa6f9 ] Hypervisors likely do not expose the SMCA feature to the guest and loading this module leads to false warnings. This module should not be loaded in guests to begin with, but people tend to do so, especially when testing kernels in VMs. And then they complain about those false warnings. Do the practical thing and do not load this module when running as a guest to avoid all that complaining. [ bp: Rewrite commit message. ] Suggested-by: Borislav Petkov Signed-off-by: Smita Koralahalli Signed-off-by: Borislav Petkov Reviewed-by: Yazen Ghannam Tested-by: Kim Phillips Link: https://lkml.kernel.org/r/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com Signed-off-by: Sasha Levin --- drivers/edac/mce_amd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c index 6c474fbef32a..b6d4ae84a9a5 100644 --- a/drivers/edac/mce_amd.c +++ b/drivers/edac/mce_amd.c @@ -1176,6 +1176,9 @@ static int __init mce_amd_init(void) c->x86_vendor != X86_VENDOR_HYGON) return -ENODEV; + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) + return -ENODEV; + if (boot_cpu_has(X86_FEATURE_SMCA)) { xec_mask = 0x3f; goto out; -- 2.30.2