From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <shiju.jose@huawei.com>
Cc: <linux-edac@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
<mchehab@kernel.org>, <linuxarm@huawei.com>
Subject: Re: [RFC PATCH 1/4] rasdaemon: Move definition for BIT and BIT_ULL to a common file
Date: Fri, 20 Jan 2023 14:28:15 +0000 [thread overview]
Message-ID: <20230120142815.00003d8b@huawei.com> (raw)
In-Reply-To: <20230119171809.1406-2-shiju.jose@huawei.com>
On Thu, 19 Jan 2023 17:18:06 +0000
<shiju.jose@huawei.com> wrote:
> From: Shiju Jose <shiju.jose@huawei.com>
>
> Move definition for BIT() and BIT_ULL() to the
> common file ras-record.h
>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Hi Shiju,
As you know I've looked at and tested this before you posted it
so I'm happy with it, except mostly places where I think there
is room to improve ras daemon in general ;)
This patch makes sense though I suspect it will one day get moved again
to an even more generic header.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
Thanks
Jonathan
> ---
> ras-non-standard-handler.h | 3 ---
> ras-record.h | 3 +++
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ras-non-standard-handler.h b/ras-non-standard-handler.h
> index 57d4cb5..393b756 100644
> --- a/ras-non-standard-handler.h
> +++ b/ras-non-standard-handler.h
> @@ -17,9 +17,6 @@
> #include "ras-events.h"
> #include "libtrace/event-parse.h"
>
> -#define BIT(nr) (1UL << (nr))
> -#define BIT_ULL(nr) (1ULL << (nr))
> -
> struct ras_ns_ev_decoder {
> struct ras_ns_ev_decoder *next;
> const char *sec_type;
> diff --git a/ras-record.h b/ras-record.h
> index d9f7733..219f10b 100644
> --- a/ras-record.h
> +++ b/ras-record.h
> @@ -25,6 +25,9 @@
>
> #define ARRAY_SIZE(x) (sizeof(x)/sizeof(*(x)))
>
> +#define BIT(nr) (1UL << (nr))
> +#define BIT_ULL(nr) (1ULL << (nr))
> +
> extern long user_hz;
>
> struct ras_events;
next prev parent reply other threads:[~2023-01-20 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 17:18 [RFC PATCH 0/4] rasdaemon: Add support for the CXL error events shiju.jose
2023-01-19 17:18 ` [RFC PATCH 1/4] rasdaemon: Move definition for BIT and BIT_ULL to a common file shiju.jose
2023-01-20 14:28 ` Jonathan Cameron [this message]
2023-01-19 17:18 ` [RFC PATCH 2/4] rasdaemon: Add support for the CXL poison events shiju.jose
2023-01-23 5:08 ` Alison Schofield
2023-01-23 11:14 ` Shiju Jose
2023-01-23 12:21 ` Jonathan Cameron
2023-01-19 17:18 ` [RFC PATCH 3/4] rasdaemon: Add support for the CXL AER uncorrectable errors shiju.jose
2023-01-20 16:21 ` Dave Jiang
2023-01-20 18:11 ` Shiju Jose
2023-01-23 12:22 ` Jonathan Cameron
2023-01-19 17:18 ` [RFC PATCH 4/4] rasdaemon: Add support for the CXL AER correctable errors shiju.jose
2023-01-23 12:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120142815.00003d8b@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mchehab@kernel.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).