linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andersson@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, bp@alien8.de,
	tony.luck@intel.com
Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, james.morse@arm.com,
	mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org,
	quic_ppareek@quicinc.com, luca.weiss@fairphone.com,
	ahalaney@redhat.com, steev@kali.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v7 08/13] arm64: dts: qcom: sm8250: Fix the base addresses of LLCC banks
Date: Tue, 14 Mar 2023 11:07:20 +0530	[thread overview]
Message-ID: <20230314053725.13623-9-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org>

The LLCC block has several banks each with a different base address
and holes in between. So it is not a correct approach to cover these
banks with a single offset/size. Instead, the individual bank's base
address needs to be specified in devicetree with the exact size.

Reported-by: Parikshit Pareek <quic_ppareek@quicinc.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 2f0e460acccd..a13cf98b1ac3 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3559,8 +3559,11 @@ usb_1_dwc3: usb@a600000 {
 
 		system-cache-controller@9200000 {
 			compatible = "qcom,sm8250-llcc";
-			reg = <0 0x09200000 0 0x1d0000>, <0 0x09600000 0 0x50000>;
-			reg-names = "llcc_base", "llcc_broadcast_base";
+			reg = <0 0x09200000 0 0x50000>, <0 0x09280000 0 0x50000>,
+			      <0 0x09300000 0 0x50000>, <0 0x09380000 0 0x50000>,
+			      <0 0x09600000 0 0x50000>;
+			reg-names = "llcc0_base", "llcc1_base", "llcc2_base",
+				    "llcc3_base", "llcc_broadcast_base";
 		};
 
 		usb_2: usb@a8f8800 {
-- 
2.25.1


  parent reply	other threads:[~2023-03-14  5:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  5:37 [PATCH v7 00/13] Qcom: LLCC/EDAC: Fix base address used for LLCC banks Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 01/13] dt-bindings: arm: msm: Update the maintainers for LLCC Manivannan Sadhasivam
2023-03-14 20:02   ` Krzysztof Kozlowski
2023-03-14  5:37 ` [PATCH v7 02/13] dt-bindings: arm: msm: Fix register regions used for LLCC banks Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 03/13] arm64: dts: qcom: sdm845: Fix the base addresses of " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 04/13] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 05/13] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 06/13] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 07/13] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-03-14  5:37 ` Manivannan Sadhasivam [this message]
2023-03-14  5:37 ` [PATCH v7 09/13] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 10/13] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 11/13] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 12/13] qcom: llcc/edac: Fix the base address used for accessing " Manivannan Sadhasivam
2023-03-14  5:37 ` [PATCH v7 13/13] soc: qcom: llcc: Do not create EDAC platform device on SDM845 Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314053725.13623-9-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mchehab@kernel.org \
    --cc=quic_ppareek@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=rric@kernel.org \
    --cc=steev@kali.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).