From: Borislav Petkov <bp@alien8.de>
To: Ruliang Lin <u202112092@hust.edu.cn>
Cc: Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@kernel.org>,
hust-os-kernel-patches@googlegroups.com,
Dongliang Mu <dzm91@hust.edu.cn>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: ras: cec: return value check of `d`
Date: Sun, 23 Apr 2023 14:56:57 +0200 [thread overview]
Message-ID: <20230423125657.GCZEUrGT7uhqNHTaLm@fat_crate.local> (raw)
In-Reply-To: <20230423122932.31274-1-u202112092@hust.edu.cn>
On Sun, Apr 23, 2023 at 08:29:32PM +0800, Ruliang Lin wrote:
> According to the documentation of the debugfs_create_dir() function,
> there is no need to check the return value of this function.
" * Drivers should generally work fine even if debugfs fails to init anyway."
Except that this particular driver won't if there is no debugfs
hierarchy created.
> Just delete the dead code.
So no, in this case it is not dead code but very much alive.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-04-23 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 12:29 [PATCH] drivers: ras: cec: return value check of `d` Ruliang Lin
2023-04-23 12:56 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230423125657.GCZEUrGT7uhqNHTaLm@fat_crate.local \
--to=bp@alien8.de \
--cc=dzm91@hust.edu.cn \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tony.luck@intel.com \
--cc=u202112092@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).