From: "Hawa, Hanna" <hhhawa@amazon.com> To: Robert Richter <rrichter@marvell.com> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "bp@alien8.de" <bp@alien8.de>, "mchehab@kernel.org" <mchehab@kernel.org>, "james.morse@arm.com" <james.morse@arm.com>, "davem@davemloft.net" <davem@davemloft.net>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>, "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>, "paulmck@linux.ibm.com" <paulmck@linux.ibm.com>, "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>, "benh@amazon.com" <benh@amazon.com>, "ronenk@amazon.com" <ronenk@amazon.com>, "talel@amazon.com" <talel@amazon.com>, "jonnyc@amazon.com" <jonnyc@amazon.com>, "hanochu@amazon.com" <hanochu@amazon.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org> Subject: Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2 EDAC Date: Tue, 3 Sep 2019 11:28:41 +0300 Message-ID: <2bce020a-bf7e-1d54-48c3-0aa6d23c84d8@amazon.com> (raw) In-Reply-To: <20190903072655.kz5x7n3477dg4yap@rric.localdomain> On 9/3/2019 10:27 AM, Robert Richter wrote: > On 15.07.19 16:24:09, Hanna Hawa wrote: >> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and >> report L2 errors. >> >> Signed-off-by: Hanna Hawa <hhhawa@amazon.com> >> --- >> MAINTAINERS | 6 ++ >> drivers/edac/Kconfig | 8 ++ >> drivers/edac/Makefile | 1 + >> drivers/edac/al_l2_edac.c | 187 ++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 202 insertions(+) >> create mode 100644 drivers/edac/al_l2_edac.c > > From a brief look at it, it seems some of my comments from 2/4 apply > here too. Please look through it. Thanks for your review, will look and fix on top of v5. Thanks, Hanna > > -Robert >
next prev parent reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-15 13:24 [PATCH v3 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa 2019-07-15 13:24 ` [PATCH v3 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC Hanna Hawa 2019-07-15 13:24 ` [PATCH v3 2/4] edac: Add support for " Hanna Hawa 2019-07-26 16:49 ` James Morse 2019-08-01 8:20 ` Hawa, Hanna 2019-09-03 7:24 ` Robert Richter 2019-09-03 8:27 ` Hawa, Hanna 2019-07-15 13:24 ` [PATCH v3 3/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC Hanna Hawa 2019-07-15 13:24 ` [PATCH v3 4/4] edac: Add support for " Hanna Hawa 2019-09-03 7:27 ` Robert Richter 2019-09-03 8:28 ` Hawa, Hanna [this message] 2019-09-03 8:46 ` Robert Richter 2019-09-03 8:58 ` Borislav Petkov 2019-09-03 19:00 ` Robert Richter
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2bce020a-bf7e-1d54-48c3-0aa6d23c84d8@amazon.com \ --to=hhhawa@amazon.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=benh@amazon.com \ --cc=bp@alien8.de \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dwmw@amazon.co.uk \ --cc=gregkh@linuxfoundation.org \ --cc=hanochu@amazon.com \ --cc=james.morse@arm.com \ --cc=jonnyc@amazon.com \ --cc=linus.walleij@linaro.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=paulmck@linux.ibm.com \ --cc=robh+dt@kernel.org \ --cc=ronenk@amazon.com \ --cc=rrichter@marvell.com \ --cc=talel@amazon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-EDAC Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \ linux-edac@vger.kernel.org public-inbox-index linux-edac Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac AGPL code for this site: git clone https://public-inbox.org/public-inbox.git