From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7E6C433DB for ; Wed, 10 Feb 2021 03:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67D3464E53 for ; Wed, 10 Feb 2021 03:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbhBJDs7 (ORCPT ); Tue, 9 Feb 2021 22:48:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbhBJDs6 (ORCPT ); Tue, 9 Feb 2021 22:48:58 -0500 X-Greylist: delayed 1248 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 09 Feb 2021 19:48:18 PST Received: from mx0b-00190b01.pphosted.com (mx0b-00190b01.pphosted.com [IPv6:2620:100:9005:57f::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DEA4C061574 for ; Tue, 9 Feb 2021 19:48:18 -0800 (PST) Received: from pps.filterd (m0122330.ppops.net [127.0.0.1]) by mx0b-00190b01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11A3PNnO006370; Wed, 10 Feb 2021 03:27:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=t4T3dzD1PuoS0Mdg+uXFCIKxbwXnc/s5vdIEywAJ69k=; b=RnFkZqW4WCQKOfJgNQTRqQSP1NRlguk9VWXSsEaDCwgYQbVK68kL+E5xgLXrUar1+u1F iFZ6i9MNYi/1r61+0tPHqqcVPXW6YKLVcRCzBiuzauJUKAD4F5MSk1jzxbKu7cNmjQOc yeptAW/6rybBq0lIwfvrRnkLGdaWngNZBtPvNa/6CfNoYFYHxJnkwNONn1oH+PESDWHs RSRQpuOUIt55Fxyyd0ucb9GLnEniJdF/Dk/KNgTKPmOyISevfSGxxLzmRa03Df4/0BQL hspVB4xSlqXQpRGbfYpnjBTtp8n1AUdCH/Zu0R9iqRyIg/zJdpwSwmO2opRqUR5o9MFB /w== Received: from prod-mail-ppoint4 (a72-247-45-32.deploy.static.akamaitechnologies.com [72.247.45.32] (may be forged)) by mx0b-00190b01.pphosted.com with ESMTP id 36hrbbwj0e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Feb 2021 03:27:23 +0000 Received: from pps.filterd (prod-mail-ppoint4.akamai.com [127.0.0.1]) by prod-mail-ppoint4.akamai.com (8.16.0.43/8.16.0.43) with SMTP id 11A3ItVf027045; Tue, 9 Feb 2021 22:27:23 -0500 Received: from prod-mail-relay18.dfw02.corp.akamai.com ([172.27.165.172]) by prod-mail-ppoint4.akamai.com with ESMTP id 36k5nknke8-1; Tue, 09 Feb 2021 22:27:23 -0500 Received: from [0.0.0.0] (unknown [172.27.119.138]) by prod-mail-relay18.dfw02.corp.akamai.com (Postfix) with ESMTP id D65BD62B; Wed, 10 Feb 2021 03:27:22 +0000 (GMT) Subject: Re: ie31200_edac missing PCI ID for i3-4370 To: Paul Marks Cc: linux-edac@vger.kernel.org, bp@alien8.de References: <77c3f46c-3519-d791-7bfe-97186d6893bb@akamai.com> From: Jason Baron Message-ID: <2ddf6488-b93a-7400-228b-bae7a2c96608@akamai.com> Date: Tue, 9 Feb 2021 22:27:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-09_08:2021-02-09,2021-02-09 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 mlxlogscore=895 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100032 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-09_08:2021-02-09,2021-02-09 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=794 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100033 X-Agari-Authentication-Results: mx.akamai.com; spf=${SPFResult} (sender IP is 72.247.45.32) smtp.mailfrom=jbaron@akamai.com smtp.helo=prod-mail-ppoint4 Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 2/9/21 6:58 PM, Paul Marks wrote: > On Tue, Feb 9, 2021 at 2:25 PM Jason Baron wrote: >> On 2/4/21 6:22 PM, Paul Marks wrote: >>> On Thu, Feb 4, 2021 at 2:59 PM Jason Baron wrote: >>>> On 1/31/21 7:07 PM, Paul Marks wrote: >>>>> I have an ASRock C226M WS with an i3-4370 CPU. >>>>> >>>>> # lspci -vnn >>>>> 00:00.0 Host bridge [0600]: Intel Corporation 4th Gen Core Processor >>>>> DRAM Controller [8086:0c00] (rev 06) >>>>> Subsystem: ASRock Incorporation 4th Gen Core Processor >>>>> DRAM Controller [1849:0c00] >>>>> Flags: bus master, fast devsel, latency 0 >>>>> Capabilities: [e0] Vendor Specific Information: Len=0c >>>>> Kernel driver in use: hsw_uncore >>>>> >>>>> But edac-util doesn't work: >>>>> >>>>> # edac-util -v >>>>> edac-util: Fatal: Unable to get EDAC data: Unable to find EDAC data in sysfs >>>>> >>>>> I tried this ham-fisted patch: >>>>> >>>>> # diff -u ./drivers/edac/ie31200_edac.c{.old,} >>>>> --- ./drivers/edac/ie31200_edac.c.old >>>>> +++ ./drivers/edac/ie31200_edac.c >>>>> @@ -58,7 +58,7 @@ >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_3 0x0150 >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_4 0x0158 >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_5 0x015c >>>>> -#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c04 >>>>> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c00 >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_7 0x0c08 >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_8 0x1918 >>>>> #define PCI_DEVICE_ID_INTEL_IE31200_HB_9 0x5918 >>>> just curious why you removed here and didn't just add? >>> This is not a serious patch, just a one-liner to demonstrate the problem. >> Ok. Any chance you can find the datasheet that shows that this >> driver is using the appropriate registers for this hw? I didn't >> find it quickly looking... >> > I wouldn't know where to begin. Do you have an example of a similar > datasheet from one of the known-good devices? > > I left "memtester" running on this machine, because it might increase > the odds of generating an ECC error someday. Hi Paul, I have a list of them at the top of: drivers/edac/ie31200_edac.c According to the following intel link it looks like '0xc[0-f]' is valid (page 52): https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/xeon-e3-1200v3-vol-2-datasheet.pdf So I'm fine with this patch (assuming it just becomes an addition). Thanks, -Jason