From: Michal Simek <michal.simek@amd.com>
To: Borislav Petkov <bp@alien8.de>,
"Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"saikrishna12468@gmail.com" <saikrishna12468@gmail.com>,
"git (AMD-Xilinx)" <git@amd.com>,
"Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP OCM
Date: Mon, 5 Dec 2022 15:49:33 +0100 [thread overview]
Message-ID: <330f1b49-eb59-c55e-3f7d-dfbf4886f247@amd.com> (raw)
In-Reply-To: <Y43vJECWJI99tc1x@zn.tnic>
On 12/5/22 14:16, Borislav Petkov wrote:
> On Mon, Dec 05, 2022 at 10:20:11AM +0000, Potthuri, Sai Krishna wrote:
>> As we communicated earlier for ZynqMP platform we have both Synopsys
>> (for DDRMC) and zynqmp_ocm_edac (for OCM) drivers. Just to be clear
>> about what this driver is targeted for, we used ocm as part of file
>> name. Ok, zynqmp_edac.c looks fine, will update.
>
> Yeah, we can always rename later, when another driver is needed. For
> now, let's keep things simple.
>
>> Ok, will update API documentation like below.
>> echo <fault_injection count> > /sys/kernel/debug/edac/ff960000.memory-controller/inject_fault_count
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Any particular reason this should not be called simply "mc0" or so?
>
> At least this is how we call them on x86...
Some history around this. Based on
https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Chapter 2.2.2 Generic Names Recommendation
memory-controller name is recommended.
Thanks,
Michal
next prev parent reply other threads:[~2022-12-05 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 7:06 [PATCH v6 0/2] EDAC: Add support for Xilinx ZynqMP OCM EDAC Sai Krishna Potthuri
2022-11-02 7:06 ` [PATCH v6 1/2] dt-bindings: edac: Add bindings for Xilinx ZynqMP OCM Sai Krishna Potthuri
2022-11-10 9:10 ` (subset) " Krzysztof Kozlowski
2022-11-10 9:12 ` Krzysztof Kozlowski
2022-11-10 10:06 ` Krzysztof Kozlowski
2022-11-02 7:06 ` [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support " Sai Krishna Potthuri
2022-11-08 18:39 ` Borislav Petkov
2022-11-09 11:21 ` Potthuri, Sai Krishna
2022-11-09 18:08 ` Borislav Petkov
2022-11-25 15:12 ` Borislav Petkov
2022-12-05 10:20 ` Potthuri, Sai Krishna
2022-12-05 13:16 ` Borislav Petkov
2022-12-05 14:49 ` Michal Simek [this message]
2022-12-05 15:19 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=330f1b49-eb59-c55e-3f7d-dfbf4886f247@amd.com \
--to=michal.simek@amd.com \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=james.morse@arm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).