From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7AB2C3404F for ; Tue, 18 Feb 2020 17:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A594322B48 for ; Tue, 18 Feb 2020 17:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgBRRca (ORCPT ); Tue, 18 Feb 2020 12:32:30 -0500 Received: from foss.arm.com ([217.140.110.172]:56946 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbgBRRc3 (ORCPT ); Tue, 18 Feb 2020 12:32:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F5C131B; Tue, 18 Feb 2020 09:32:29 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13CAC3F703; Tue, 18 Feb 2020 09:32:24 -0800 (PST) Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk To: Will Deacon , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, soc@kernel.org, Andre Przywara , Robert Richter , Jon Loeliger , Alexander Graf , Matthias Brugger , Mark Langsdorf , Alex Williamson , Borislav Petkov , Cornelia Huck , Daniel Lezcano , "David S. Miller" , devicetree@vger.kernel.org, Eric Auger , iommu@lists.linux-foundation.org, James Morse , Jens Axboe , Joerg Roedel , kvm@vger.kernel.org, linux-clk@vger.kernel.org, linux-edac@vger.kernel.org, linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, Mauro Carvalho Chehab , netdev@vger.kernel.org, "Rafael J. Wysocki" , Stephen Boyd , Tony Luck , Viresh Kumar References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> From: Robin Murphy Message-ID: <38be84e3-d23f-1e91-4d3d-87fc11d7c089@arm.com> Date: Tue, 18 Feb 2020 17:32:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218172000.GF1133@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 18/02/2020 5:20 pm, Will Deacon wrote: > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Cc: iommu@lists.linux-foundation.org >> Signed-off-by: Rob Herring >> --- >> Do not apply yet. > > Pleeeeease? ;) > >> drivers/iommu/arm-smmu-impl.c | 43 ----------------------------------- Presumably we also want to remove the definition of the option from binding too. >> 1 file changed, 43 deletions(-) > > Yes, I'm happy to get rid of this. Sadly, I don't think we can remove > anything from 'struct arm_smmu_impl' because most implementations fall > just short of perfect. Right, this served as the prototype for register access hooks, but we have at least one other known user for those. > Anyway, let me know when I can push the button and I'll queue this in > the arm-smmu tree. FWIW the quirk has proven useful in other circumstances too, but I imagine if we ever have to prototype an integration on VExpress-CA9 again, reverting this patch will hardly be the most unpleasant part :) Robin.