linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>, Andi Kleen <ak@linux.intel.com>
Cc: Jeremy Cline <jcline@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Laura Abbott <labbott@redhat.com>
Subject: x86/mce: suspicious RCU usage in 4.13.4
Date: Wed, 11 Oct 2017 21:34:22 +0000	[thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F770038E5@ORSMSX114.amr.corp.intel.com> (raw)

> here's a second attempt at a more rigorous simplification: RCU stuff is
> gone and only a single loop scans through the elements.

The dev_mce_log() changes look good now.

You can apply the axe to more bits of mce_chrdev_read() though. Like that

	while (!m->finished) {

we hold the mutex, the writer of that holds the mutex ... the spin loop is going to always
time out.  

-Tony

             reply	other threads:[~2017-10-11 21:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 21:34 Luck, Tony [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-01 20:07 x86/mce: suspicious RCU usage in 4.13.4 Luck, Tony
2017-11-01 16:47 Borislav Petkov
2017-11-01 14:56 Laura Abbott
2017-10-16 18:28 Luck, Tony
2017-10-15  9:40 Borislav Petkov
2017-10-12 22:13 Andi Kleen
2017-10-12  9:02 Borislav Petkov
2017-10-11 23:11 Andi Kleen
2017-10-11 11:50 Borislav Petkov
2017-10-10 20:13 Andi Kleen
2017-10-10 20:08 Luck, Tony
2017-10-10 19:44 Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3908561D78D1C84285E8C5FCA982C28F770038E5@ORSMSX114.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jcline@redhat.com \
    --cc=labbott@redhat.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).